Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: third_party/sqlite/BUILD.gn

Issue 1961823003: Remove SQLITE_NO_SYNC on Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/sqlite/sqlite.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Controls whether the build should uses the version of sqlite3 library 6 # Controls whether the build should uses the version of sqlite3 library
7 # shipped with the system (currently only supported on iOS) or the one 7 # shipped with the system (currently only supported on iOS) or the one
8 # shipped with Chromium source. 8 # shipped with Chromium source.
9 use_system_sqlite = is_ios 9 use_system_sqlite = is_ios
10 } 10 }
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 # src/src/parse.py 97 # src/src/parse.py
98 # src/tool/mkkeywordhash.c 98 # src/tool/mkkeywordhash.c
99 ] 99 ]
100 if (is_component_build) { 100 if (is_component_build) {
101 if (is_win) { 101 if (is_win) {
102 defines += [ "SQLITE_API=__declspec(dllexport)" ] 102 defines += [ "SQLITE_API=__declspec(dllexport)" ]
103 } else { 103 } else {
104 defines += [ "SQLITE_API=__attribute__((visibility(\"default\")))" ] 104 defines += [ "SQLITE_API=__attribute__((visibility(\"default\")))" ]
105 } 105 }
106 } 106 }
107 if (is_chromeos) {
108 defines += [
109 # Despite obvious warnings about not using this flag in deployment, we
110 # are turning off sync in ChromeOS and relying on the underlying
111 # journaling filesystem to do error recovery properly. It's much faster.
112 "SQLITE_NO_SYNC",
113 ]
114 }
115 if (is_posix) { 107 if (is_posix) {
116 defines += [ 108 defines += [
117 # Allow xSleep() call on Unix to use usleep() rather than sleep(), so it 109 # Allow xSleep() call on Unix to use usleep() rather than sleep(), so it
118 # will have microsecond precision. Should only affect contended 110 # will have microsecond precision. Should only affect contended
119 # databases via the busy callback. Browser profile databases are mostly 111 # databases via the busy callback. Browser profile databases are mostly
120 # exclusive, but renderer databases may allow for contention. 112 # exclusive, but renderer databases may allow for contention.
121 "HAVE_USLEEP=1", 113 "HAVE_USLEEP=1",
122 114
123 # Use pread/pwrite directly rather than emulating them. 115 # Use pread/pwrite directly rather than emulating them.
124 "USE_PREAD=1", 116 "USE_PREAD=1",
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 "//third_party/icu", 249 "//third_party/icu",
258 ] 250 ]
259 if (is_clang) { 251 if (is_clang) {
260 # src/ext/icu/icu.c uses assert(!"string") which causes warnings about 252 # src/ext/icu/icu.c uses assert(!"string") which causes warnings about
261 # conversion from string literal to bool. 253 # conversion from string literal to bool.
262 configs -= [ "//build/config/clang:extra_warnings" ] 254 configs -= [ "//build/config/clang:extra_warnings" ]
263 } 255 }
264 } 256 }
265 } 257 }
266 } 258 }
OLDNEW
« no previous file with comments | « no previous file | third_party/sqlite/sqlite.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698