Remove SQLITE_NO_SYNC on Chrome OS

Remove SQLITE_NO_SYNC on Chrome OS

We agreed to remove this flag as the underlying FS doesn't seem to be
able to reliably recover from corruption when a crash or panic occurs
(see crbug.com/502898).

BUG=592101
TEST= Check the "Profile.ProfileError" metric to determine the impact of this flag removal.

Committed: https://crrev.com/d53cc59b6781b26babf0721fc9c001a32b3dada8
Cr-Commit-Position: refs/heads/master@{#392477}

[afakhry, 2016-05-09 21:36:19]

afakhry@chromium.org changed reviewers:
+ shess@chromium.org

[afakhry, 2016-05-09 21:36:19]

Could you please take a look? Thanks!

[Scott Hess - ex-Googler, 2016-05-09 22:30:16]

LGTM.

Maybe update the bug with any metrics you're thinking will be useful in
evaluating the impact - positive _or_ negative.

[afakhry, 2016-05-09 22:35:54]

Description was changed from

==========
Remove SQLITE_NO_SYNC on Chrome OS

We agreed to remove this flag as the underlying FS doesn't seem to be
able to reliably recover from corruption when a crash or panic occurs
(see crbug.com/502898).

BUG=592101
==========

to

==========
Remove SQLITE_NO_SYNC on Chrome OS

We agreed to remove this flag as the underlying FS doesn't seem to be
able to reliably recover from corruption when a crash or panic occurs
(see crbug.com/502898).

BUG=592101
TEST= Check the "Profile.ProfileError" metric to determine the impact of this
flag removal.
==========

[afakhry, 2016-05-09 22:37:17]

On 2016/05/09 22:30:16, Scott Hess wrote:
> LGTM.
> 
> Maybe update the bug with any metrics you're thinking will be useful in
> evaluating the impact - positive _or_ negative.

Thanks! Done.

[afakhry, 2016-05-09 22:53:30]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-05-09 22:54:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961823003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961823003/1

[commit-bot: I haz the power, 2016-05-09 23:45:46]

Description was changed from

==========
Remove SQLITE_NO_SYNC on Chrome OS

We agreed to remove this flag as the underlying FS doesn't seem to be
able to reliably recover from corruption when a crash or panic occurs
(see crbug.com/502898).

BUG=592101
TEST= Check the "Profile.ProfileError" metric to determine the impact of this
flag removal.
==========

to

==========
Remove SQLITE_NO_SYNC on Chrome OS

We agreed to remove this flag as the underlying FS doesn't seem to be
able to reliably recover from corruption when a crash or panic occurs
(see crbug.com/502898).

BUG=592101
TEST= Check the "Profile.ProfileError" metric to determine the impact of this
flag removal.
==========

[commit-bot: I haz the power, 2016-05-09 23:45:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-09 23:47:25]

Description was changed from

==========
Remove SQLITE_NO_SYNC on Chrome OS

We agreed to remove this flag as the underlying FS doesn't seem to be
able to reliably recover from corruption when a crash or panic occurs
(see crbug.com/502898).

BUG=592101
TEST= Check the "Profile.ProfileError" metric to determine the impact of this
flag removal.
==========

to

==========
Remove SQLITE_NO_SYNC on Chrome OS

We agreed to remove this flag as the underlying FS doesn't seem to be
able to reliably recover from corruption when a crash or panic occurs
(see crbug.com/502898).

BUG=592101
TEST= Check the "Profile.ProfileError" metric to determine the impact of this
flag removal.

Committed: https://crrev.com/d53cc59b6781b26babf0721fc9c001a32b3dada8
Cr-Commit-Position: refs/heads/master@{#392477}
==========

[commit-bot: I haz the power, 2016-05-09 23:47:26]

Patchset 1 (id:??) landed as
https://crrev.com/d53cc59b6781b26babf0721fc9c001a32b3dada8
Cr-Commit-Position: refs/heads/master@{#392477}