Show no-notification message in the bottom label of message center

Show no-notification message in the bottom label of message center

This patch shows the no-notification message ("You have no notifications") in the bottom label of message center, which shows "Notification" in general.

Previously, the message was shown at the other message view above the label. But it will be removed by the separated patch (crrev.com/1961803002).

BUG=599891
TEST=manually tested

Committed: https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6
Cr-Commit-Position: refs/heads/master@{#393798}

[yoshiki, 2016-05-10 04:14:51]

Patchset #2 (id:20001) has been deleted

[yoshiki, 2016-05-10 04:14:57]

Patchset #1 (id:1) has been deleted

[yoshiki, 2016-05-10 04:16:59]

Description was changed from

==========
wip

BUG=
==========

to

==========
Show no-notification message on the message center label at bottom

BUG=
==========

[yoshiki, 2016-05-10 04:20:32]

Description was changed from

==========
Show no-notification message on the message center label at bottom

BUG=
==========

to

==========
Show no-notification message in bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

BUG=599891
==========

[yoshiki, 2016-05-12 12:49:13]

Patchset #1 (id:40001) has been deleted

[yoshiki, 2016-05-12 19:02:12]

Description was changed from

==========
Show no-notification message in bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

BUG=599891
==========

to

==========
Show no-notification message in the bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

Previously, the message was shown at the other message view above the label. But
it will be removed by the separated patch (crrev.com/1961803002).

BUG=599891
==========

[yoshiki, 2016-05-12 19:02:12]

yoshiki@chromium.org changed reviewers:
+ dewittj@chromium.org

[yoshiki, 2016-05-12 19:43:04]

Description was changed from

==========
Show no-notification message in the bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

Previously, the message was shown at the other message view above the label. But
it will be removed by the separated patch (crrev.com/1961803002).

BUG=599891
==========

to

==========
Show no-notification message in the bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

Previously, the message was shown at the other message view above the label. But
it will be removed by the separated patch (crrev.com/1961803002).

BUG=599891
TEST=manually tested
==========

[yoshiki, 2016-05-12 19:43:12]

Justin, PTAL. Thanks.

[dewittj, 2016-05-12 19:48:36]

lgtm, with a nit

https://codereview.chromium.org/1961813002/diff/60001/ui/strings/ui_strings.grd
File ui/strings/ui_strings.grd (right):

https://codereview.chromium.org/1961813002/diff/60001/ui/strings/ui_strings.g...
ui/strings/ui_strings.grd:605: <message
name="IDS_MESSAGE_CENTER_FOOTER_NO_NOTIFICATION" desc="The label in the footer
of the message center when there is no notification to show">
Why not just reuse IDS_MESSAGE_CENTER_NO_MESSAGES?

[yoshiki, 2016-05-16 05:41:01]

Thanks!

https://codereview.chromium.org/1961813002/diff/60001/ui/strings/ui_strings.grd
File ui/strings/ui_strings.grd (right):

https://codereview.chromium.org/1961813002/diff/60001/ui/strings/ui_strings.g...
ui/strings/ui_strings.grd:605: <message
name="IDS_MESSAGE_CENTER_FOOTER_NO_NOTIFICATION" desc="The label in the footer
of the message center when there is no notification to show">
On 2016/05/12 19:48:36, dewittj wrote:
> Why not just reuse IDS_MESSAGE_CENTER_NO_MESSAGES?

Done.

[yoshiki, 2016-05-16 05:41:05]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2016-05-16 05:41:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/1961813002/#ps80001
(title: "Reused the existing string")

[commit-bot: I haz the power, 2016-05-16 05:41:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961813002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961813002/80001

[commit-bot: I haz the power, 2016-05-16 06:53:56]

Description was changed from

==========
Show no-notification message in the bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

Previously, the message was shown at the other message view above the label. But
it will be removed by the separated patch (crrev.com/1961803002).

BUG=599891
TEST=manually tested
==========

to

==========
Show no-notification message in the bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

Previously, the message was shown at the other message view above the label. But
it will be removed by the separated patch (crrev.com/1961803002).

BUG=599891
TEST=manually tested
==========

[commit-bot: I haz the power, 2016-05-16 06:53:57]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-05-16 06:55:47]

Description was changed from

==========
Show no-notification message in the bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

Previously, the message was shown at the other message view above the label. But
it will be removed by the separated patch (crrev.com/1961803002).

BUG=599891
TEST=manually tested
==========

to

==========
Show no-notification message in the bottom label of message center

This patch shows the no-notification message ("You have no notifications") in
the bottom label of message center, which shows "Notification" in general.

Previously, the message was shown at the other message view above the label. But
it will be removed by the separated patch (crrev.com/1961803002).

BUG=599891
TEST=manually tested

Committed: https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6
Cr-Commit-Position: refs/heads/master@{#393798}
==========

[commit-bot: I haz the power, 2016-05-16 06:55:48]

Patchset 2 (id:??) landed as
https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6
Cr-Commit-Position: refs/heads/master@{#393798}