Remove NoNotificationMessageView from empty message center

Remove NoNotificationMessageView from message center

This patch removes NoNotificationMessageView which is shown  when the message center has no notification, and instead the separated patch (crrev.com/1961813002) will show the no-notification message at the bottom label.

This patch also fixes the geometry bug, which calculated the height wrongly, in ui/message_center/views/message_center_view.cc:286.

BUG=599891
TEST=manually tested

Committed: https://crrev.com/2768accc154d067704fb501967de68cba9fa4c3b
Cr-Commit-Position: refs/heads/master@{#393833}

[yoshiki, 2016-05-12 18:55:59]

Patchset #1 (id:1) has been deleted

[yoshiki, 2016-05-12 18:56:10]

Patchset #2 (id:40001) has been deleted

[yoshiki, 2016-05-12 18:56:15]

Patchset #1 (id:20001) has been deleted

[yoshiki, 2016-05-12 18:56:28]

Patchset #2 (id:80001) has been deleted

[yoshiki, 2016-05-12 19:00:02]

Description was changed from

==========
wip

BUG=
==========

to

==========
Remove NoNotificationMessageView from empty message center

This patch removes NoNotificationMessageView from empty message center and
instead the separated patch (crrev.com/1961813002) will show the no-notification
message at the bottom label.

BUG=599891
TEST=manually tested
==========

[yoshiki, 2016-05-12 19:00:03]

yoshiki@chromium.org changed reviewers:
+ dewittj@chromium.org

[yoshiki, 2016-05-12 19:17:34]

Description was changed from

==========
Remove NoNotificationMessageView from empty message center

This patch removes NoNotificationMessageView from empty message center and
instead the separated patch (crrev.com/1961813002) will show the no-notification
message at the bottom label.

BUG=599891
TEST=manually tested
==========

to

==========
Remove NoNotificationMessageView from message center

This patch removes NoNotificationMessageView which is shown  when the message
center has no notification, and instead the separated patch
(crrev.com/1961813002) will show the no-notification message at the bottom
label.

BUG=599891
TEST=manually tested
==========

[yoshiki, 2016-05-12 19:40:14]

Patchset #1 (id:60001) has been deleted

[yoshiki, 2016-05-12 19:42:34]

Justin, PTAL. Thanks.

[dewittj, 2016-05-12 20:03:04]

Mostly looks great.

Can you add some message_center_view_unittests to cover the new Mode that you're
introducing here?

[yoshiki, 2016-05-13 05:08:13]

Justin, I added tests, PTAL again? Thanks.

[yoshiki, 2016-05-13 05:10:48]

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
File ui/message_center/views/message_center_view.cc (right):

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
ui/message_center/views/message_center_view.cc:286: (button_border ?
button_border->GetInsets().height() : 0);
As you mentioned in comment in crrev.com/1926113002, this fixes a separate bug.
Is it ok to fix it in this patch?

[dewittj, 2016-05-13 19:54:13]

lgtm with a nit, thanks!

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
File ui/message_center/views/message_center_view.cc (right):

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
ui/message_center/views/message_center_view.cc:286: (button_border ?
button_border->GetInsets().height() : 0);
On 2016/05/13 05:10:48, yoshiki wrote:
> As you mentioned in comment in crrev.com/1926113002, this fixes a separate
bug.
> Is it ok to fix it in this patch?

OK, just mention it in the CL comment.

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
File ui/message_center/views/message_center_view_unittest.cc (right):

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
ui/message_center/views/message_center_view_unittest.cc:628:
RemoveNotification(kNotificationId1, false);
nit: make a helper function that just removes all notifications.

[yoshiki, 2016-05-16 05:40:14]

Description was changed from

==========
Remove NoNotificationMessageView from message center

This patch removes NoNotificationMessageView which is shown  when the message
center has no notification, and instead the separated patch
(crrev.com/1961813002) will show the no-notification message at the bottom
label.

BUG=599891
TEST=manually tested
==========

to

==========
Remove NoNotificationMessageView from message center

This patch removes NoNotificationMessageView which is shown  when the message
center has no notification, and instead the separated patch
(crrev.com/1961813002) will show the no-notification message at the bottom
label.

This patch also fixes the geometry bug, which calculated the height wrongly, in
ui/message_center/views/message_center_view.cc:286.

BUG=599891
TEST=manually tested
==========

[yoshiki, 2016-05-16 08:53:18]

Patchset #4 (id:160001) has been deleted

[yoshiki, 2016-05-16 08:54:38]

Patchset #3 (id:140001) has been deleted

[yoshiki, 2016-05-16 15:05:53]

Thank you for reviewing!

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
File ui/message_center/views/message_center_view.cc (right):

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
ui/message_center/views/message_center_view.cc:286: (button_border ?
button_border->GetInsets().height() : 0);
On 2016/05/13 19:54:13, dewittj wrote:
> On 2016/05/13 05:10:48, yoshiki wrote:
> > As you mentioned in comment in crrev.com/1926113002, this fixes a separate
> bug.
> > Is it ok to fix it in this patch?
> 
> OK, just mention it in the CL comment.

Done.

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
File ui/message_center/views/message_center_view_unittest.cc (right):

https://codereview.chromium.org/1961803002/diff/120001/ui/message_center/view...
ui/message_center/views/message_center_view_unittest.cc:628:
RemoveNotification(kNotificationId1, false);
On 2016/05/13 19:54:13, dewittj wrote:
> nit: make a helper function that just removes all notifications.

Done.

[yoshiki, 2016-05-16 15:05:59]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2016-05-16 15:05:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/1961803002/#ps200001
(title: ".")

[commit-bot: I haz the power, 2016-05-16 15:06:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961803002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961803002/200001

[commit-bot: I haz the power, 2016-05-16 15:09:17]

Description was changed from

==========
Remove NoNotificationMessageView from message center

This patch removes NoNotificationMessageView which is shown  when the message
center has no notification, and instead the separated patch
(crrev.com/1961813002) will show the no-notification message at the bottom
label.

This patch also fixes the geometry bug, which calculated the height wrongly, in
ui/message_center/views/message_center_view.cc:286.

BUG=599891
TEST=manually tested
==========

to

==========
Remove NoNotificationMessageView from message center

This patch removes NoNotificationMessageView which is shown  when the message
center has no notification, and instead the separated patch
(crrev.com/1961813002) will show the no-notification message at the bottom
label.

This patch also fixes the geometry bug, which calculated the height wrongly, in
ui/message_center/views/message_center_view.cc:286.

BUG=599891
TEST=manually tested
==========

[commit-bot: I haz the power, 2016-05-16 15:09:18]

Committed patchset #4 (id:200001)

[commit-bot: I haz the power, 2016-05-16 15:10:57]

Description was changed from

==========
Remove NoNotificationMessageView from message center

This patch removes NoNotificationMessageView which is shown  when the message
center has no notification, and instead the separated patch
(crrev.com/1961813002) will show the no-notification message at the bottom
label.

This patch also fixes the geometry bug, which calculated the height wrongly, in
ui/message_center/views/message_center_view.cc:286.

BUG=599891
TEST=manually tested
==========

to

==========
Remove NoNotificationMessageView from message center

This patch removes NoNotificationMessageView which is shown  when the message
center has no notification, and instead the separated patch
(crrev.com/1961813002) will show the no-notification message at the bottom
label.

This patch also fixes the geometry bug, which calculated the height wrongly, in
ui/message_center/views/message_center_view.cc:286.

BUG=599891
TEST=manually tested

Committed: https://crrev.com/2768accc154d067704fb501967de68cba9fa4c3b
Cr-Commit-Position: refs/heads/master@{#393833}
==========

[commit-bot: I haz the power, 2016-05-16 15:10:58]

Patchset 4 (id:??) landed as
https://crrev.com/2768accc154d067704fb501967de68cba9fa4c3b
Cr-Commit-Position: refs/heads/master@{#393833}