Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: ui/message_center/message_center_tray.cc

Issue 1961793002: Show the unread button even without any unread notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/web_notification/web_notification_tray.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_center_tray.cc
diff --git a/ui/message_center/message_center_tray.cc b/ui/message_center/message_center_tray.cc
index ffafe5d9092ade762291d3577c3e772ab715ec8c..023cd061c3aea07eca541b4a46de5631ef911010 100644
--- a/ui/message_center/message_center_tray.cc
+++ b/ui/message_center/message_center_tray.cc
@@ -258,9 +258,6 @@ void MessageCenterTray::OnBlockingStateChanged(NotificationBlocker* blocker) {
}
void MessageCenterTray::OnMessageCenterChanged() {
- if (message_center_visible_ && message_center_->NotificationCount() == 0)
- HideMessageCenterBubble();
dewittj 2016/05/09 16:27:52 This change isn't reflected in the CL description
yoshiki 2016/05/10 03:52:07 I thought it was intended. But per PM discussion,
-
if (popups_visible_ && !message_center_->HasPopupNotifications())
HidePopupBubbleInternal();
else if (!popups_visible_ && message_center_->HasPopupNotifications())
« no previous file with comments | « ash/system/web_notification/web_notification_tray.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698