Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1961793002:
Show the unread button even without any unread notifications (Closed)
|
Created:
4 years, 7 months ago by yoshiki Modified:
4 years, 7 months ago CC:
chromium-reviews, Peter Beverloo, kalyank, mlamouri+watch-notifications_chromium.org, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionShow the unread button even without any unread notifications
The unread button was shown only when there are any notifications.
This patch shows it even when there is no notifications.
BUG=599891
Committed: https://crrev.com/65dafe01584f929280381544785961d5d5d26b3d
Cr-Commit-Position: refs/heads/master@{#393151}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressed comment. #
Messages
Total messages: 22 (9 generated)
Description was changed from ========== Show the unread button even without any unread notifications The unread button was shown only when there are any notifications. This patch shows it even when there is no notifications. BUG=599891 ========== to ========== Show the unread button even without any unread notifications The unread button was shown only when there are any notifications. This patch shows it even when there is no notifications. BUG=599891 ==========
Patchset #2 (id:20001) has been deleted
yoshiki@chromium.org changed reviewers: + dewittj@chromium.org
Justin, this is a part of crrev.com/1926113002. PTAL. Thanks.
https://codereview.chromium.org/1961793002/diff/1/ui/message_center/message_c... File ui/message_center/message_center_tray.cc (left): https://codereview.chromium.org/1961793002/diff/1/ui/message_center/message_c... ui/message_center/message_center_tray.cc:262: HideMessageCenterBubble(); This change isn't reflected in the CL description - it look like it leaves the message center open even after every notification is gone. Is that intended?
PTAL https://codereview.chromium.org/1961793002/diff/1/ui/message_center/message_c... File ui/message_center/message_center_tray.cc (left): https://codereview.chromium.org/1961793002/diff/1/ui/message_center/message_c... ui/message_center/message_center_tray.cc:262: HideMessageCenterBubble(); On 2016/05/09 16:27:52, dewittj wrote: > This change isn't reflected in the CL description - it look like it leaves the > message center open even after every notification is gone. Is that intended? I thought it was intended. But per PM discussion, we don't need to do it.
Justin, ping?
apologies for the delay, lgtm
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961793002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
yoshiki@chromium.org changed reviewers: + oshima@chromium.org
Oshima-san, could you approve this change? Thanks.
assuming you run "git cl format", lgtm
On 2016/05/12 01:49:29, oshima wrote: > assuming you run "git cl format", lgtm It has already done. Thanks.
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961793002/40001
Message was sent while issue was closed.
Description was changed from ========== Show the unread button even without any unread notifications The unread button was shown only when there are any notifications. This patch shows it even when there is no notifications. BUG=599891 ========== to ========== Show the unread button even without any unread notifications The unread button was shown only when there are any notifications. This patch shows it even when there is no notifications. BUG=599891 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Show the unread button even without any unread notifications The unread button was shown only when there are any notifications. This patch shows it even when there is no notifications. BUG=599891 ========== to ========== Show the unread button even without any unread notifications The unread button was shown only when there are any notifications. This patch shows it even when there is no notifications. BUG=599891 Committed: https://crrev.com/65dafe01584f929280381544785961d5d5d26b3d Cr-Commit-Position: refs/heads/master@{#393151} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/65dafe01584f929280381544785961d5d5d26b3d Cr-Commit-Position: refs/heads/master@{#393151} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
