Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: runtime/bin/vmservice/client/lib/src/service/object.dart

Issue 196173022: Fix PrintToJSONStream for oddball functions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/vm_view.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/service/object.dart
diff --git a/runtime/bin/vmservice/client/lib/src/service/object.dart b/runtime/bin/vmservice/client/lib/src/service/object.dart
index 43b98f44461816828df7cc8cb162ff7699676c9e..4dd87c459bae2d9c1ab2117db18c99f8dbd2d80b 100644
--- a/runtime/bin/vmservice/client/lib/src/service/object.dart
+++ b/runtime/bin/vmservice/client/lib/src/service/object.dart
@@ -543,11 +543,13 @@ class Isolate extends ServiceObjectOwner {
/// A [ServiceObject] which implements [ObservableMap].
class ServiceMap extends ServiceObject implements ObservableMap {
final ObservableMap _map = new ObservableMap();
+ static String objectIdRingPrefix = 'objects/';
bool get canCache {
return (_serviceType == 'Class' ||
_serviceType == 'Function' ||
- _serviceType == 'Library');
+ _serviceType == 'Library') &&
+ !_id.startsWith(objectIdRingPrefix);
}
bool get immutable => canCache;
@@ -568,7 +570,7 @@ class ServiceMap extends ServiceObject implements ObservableMap {
// right thing to do here?
_map.clear();
_map.addAll(map);
-
+
name = _map['user_name'];
vmName = _map['name'];
_upgradeValues();
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/vm_view.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698