Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 196173021: ARM64: Prevent compilers to optimize away NaN negation in tests. (Closed)

Created:
6 years, 9 months ago by baptiste.afsa1
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Prevent compilers to optimize away NaN negation in tests. BUG=v8:3226 R=ulan@chromium.org, jochen@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20213

Patch Set 1 #

Patch Set 2 : update status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -40 lines) Patch
M src/arm64/simulator-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 2 chunks +56 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
baptiste.afsa1
PTAL This patch fixes v8 issue 3226.
6 years, 9 months ago (2014-03-24 15:58:52 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-24 16:28:24 UTC) #2
jochen (gone - plz use gerrit)
On 2014/03/24 16:28:24, ulan wrote: > lgtm Thanks! Can you also update the cctest.status file?
6 years, 9 months ago (2014-03-24 16:58:40 UTC) #3
baptiste.afsa1
On 2014/03/24 16:58:40, jochen wrote: > On 2014/03/24 16:28:24, ulan wrote: > > lgtm > ...
6 years, 9 months ago (2014-03-24 17:20:57 UTC) #4
baptiste.afsa1
6 years, 9 months ago (2014-03-24 17:44:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20213 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698