Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196173020: Remove deprecated getPresentationAttribute (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, kouhei+svg_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GzMh_HfjUVc This method is removed is from SVG2, uses the deprecated CSSValue and use counter data indicates it is little or not used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170077

Patch Set 1 #

Patch Set 2 : Remove getPresentationAttribute tests #

Patch Set 3 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -115 lines) Patch
D LayoutTests/platform/mac/svg/custom/getPresentationAttribute-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/win/svg/custom/getPresentationAttribute-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/svg/custom/getPresentationAttribute.svg View 1 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/svg/custom/path-getPresentationAttribute-crash.html View 1 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/svg/custom/path-getPresentationAttribute-crash-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/svg/SVGElement.idl View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
rwlbuis
Patch acting out the intent to remove.
6 years, 9 months ago (2014-03-26 12:23:01 UTC) #1
Stephen Chennney
lgtm
6 years, 9 months ago (2014-03-26 14:24:08 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-26 14:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/196173020/10001
6 years, 9 months ago (2014-03-26 14:30:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 14:30:58 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/svg/SVGElement.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 14:30:59 UTC) #6
pdr.
On 2014/03/26 14:30:59, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 9 months ago (2014-03-26 16:28:03 UTC) #7
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-26 16:52:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/196173020/90001
6 years, 9 months ago (2014-03-26 16:52:45 UTC) #9
commit-bot: I haz the power
Change committed as 170077
6 years, 9 months ago (2014-03-26 18:01:49 UTC) #10
rwlbuis
On 2014/03/26 16:28:03, pdr wrote: > On 2014/03/26 14:30:59, I haz the power (commit-bot) wrote: ...
6 years, 9 months ago (2014-03-26 20:35:54 UTC) #11
pdr.
6 years, 9 months ago (2014-03-27 20:35:06 UTC) #12
Message was sent while issue was closed. 
On 2014/03/26 20:35:54, rwlbuis wrote:
> On 2014/03/26 16:28:03, pdr wrote:
> > On 2014/03/26 14:30:59, I haz the power (commit-bot) wrote:
> > > Failed to apply patch for Source/core/svg/SVGElement.idl:
> > > While running patch -p1 --forward --force --no-backup-if-mismatch;
> > >   patching file Source/core/svg/SVGElement.idl
> > >   Hunk #1 FAILED at 32.
> > >   1 out of 1 hunk FAILED -- saving rejects to file
> > > Source/core/svg/SVGElement.idl.rej
> > > 
> > > Patch:       Source/core/svg/SVGElement.idl
> > > Index: Source/core/svg/SVGElement.idl
> > > diff --git a/Source/core/svg/SVGElement.idl
b/Source/core/svg/SVGElement.idl
> > > index
> > >
> >
>
1608f33d02d7ef3d7c0404c3d42e6a15fb05b2e3..6822937de286f18b9bc89e6691f3150d3a143a1f
> > > 100644
> > > --- a/Source/core/svg/SVGElement.idl
> > > +++ b/Source/core/svg/SVGElement.idl
> > > @@ -32,10 +32,6 @@
> > >  
> > >      [MeasureAs=SVGClassName] readonly attribute SVGAnimatedString
> className;
> > >      readonly attribute CSSStyleDeclaration style;
> > > -
> > > -    // CSSValue was deprecated in 2003:
> > > -    // http://lists.w3.org/Archives/Public/www-style/2003Oct/0347.html
> > > -    [DeprecateAs=SVGElementGetPresentationAttribute] CSSValue
> > > getPresentationAttribute([Default=Undefined] optional DOMString name);
> > >  };
> > >  
> > >  SVGElement implements GlobalEventHandlers;
> > 
> > Can we wait just a little longer in case there's remaining comments on
> > blink-dev? I think we usually wait 1 week.
> 
> Oops I did not see your message :( Let me know if you want a revert.

I don't think it's too big of a deal; mistakes happen. I think we should leave
it in the tree, but please keep an eye on the blink-dev thread.

Powered by Google App Engine
This is Rietveld 408576698