Change auto-roll to auto-push for automatic trunk pushes.

tools/push-to-trunk/auto_push.py

 #!/usr/bin/env python
 # Copyright 2013 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
@@ skipping 37 matching lines @@
 
 
 class Preparation(Step):
   MESSAGE = "Preparation."
 
   def RunStep(self):
     self.InitialEnvironmentChecks()
     self.CommonPrepare()
 
 
-class CheckAutoRollSettings(Step):
+class CheckAutoPushSettings(Step):
   MESSAGE = "Checking settings file."
 
   def RunStep(self):
     settings_file = os.path.realpath(self.Config(SETTINGS_LOCATION))
     if os.path.exists(settings_file):
       settings_dict = json.loads(FileToText(settings_file))
       if settings_dict.get("enable_auto_roll") is False:
         self.Die("Push to trunk disabled by auto-roll settings file: %s"
                  % settings_file)
 
@@ skipping 38 matching lines @@
     # improved by counting only the revisions on bleeding_edge.
     if int(self["lkgr"]) - int(last_push_be) < 10:  # pragma: no cover
       # This makes sure the script doesn't push twice in a row when the cron
       # job retries several times.
       self.Die("Last push too recently: %s" % last_push_be)
 
 
 class PushToTrunk(Step):
   MESSAGE = "Pushing to trunk if specified."
 
-  def PushTreeStatus(self, message):
-    if not self._options.status_password:
-      print "Skipping tree status update without password file."
-      return
-    params = {
-      "message": message,
-      "username": "v8-auto-roll@chromium.org",
-      "password": FileToText(self._options.status_password).strip(),
-    }
-    params = urllib.urlencode(params)
-    print "Pushing tree status: '%s'" % message
-    self.ReadURL("https://v8-status.appspot.com/status", params,
-                 wait_plan=[5, 20])
-
   def RunStep(self):
     print "Pushing lkgr %s to trunk." % self["lkgr"]
-    self.PushTreeStatus("Tree is closed (preparing to push)")
 
     # TODO(machenbach): Update the script before calling it.
-    try:
-      if self._options.push:
-        P = push_to_trunk.PushToTrunk
-        self._side_effect_handler.Call(
-            P(push_to_trunk.CONFIG, self._side_effect_handler).Run,
-            ["--author", self._options.author,
-             "--reviewer", self._options.reviewer,
-             "--revision", self["lkgr"],
-             "--force"])
-    finally:
-      self.PushTreeStatus(self["tree_message"])
+    if self._options.push:
+      P = push_to_trunk.PushToTrunk
+      self._side_effect_handler.Call(
+          P(push_to_trunk.CONFIG, self._side_effect_handler).Run,
+          ["--author", self._options.author,
+           "--reviewer", self._options.reviewer,
+           "--revision", self["lkgr"],
+           "--force"])
 
 
-class AutoRoll(ScriptsBase):
+class AutoPush(ScriptsBase):
   def _PrepareOptions(self, parser):
-    parser.add_argument("-c", "--chromium",
-                        help=("Deprecated."))
     parser.add_argument("-p", "--push",
                         help="Push to trunk. Dry run if unspecified.",
                         default=False, action="store_true")
-    parser.add_argument("--status-password",
-                        help="A file with the password to the status app.")
 
   def _ProcessOptions(self, options):
     if not options.author or not options.reviewer:  # pragma: no cover
       print "You need to specify author and reviewer."
       return False
     options.requires_editor = False
     return True
 
   def _Steps(self):
     return [
       Preparation,
-      CheckAutoRollSettings,
+      CheckAutoPushSettings,
       CheckTreeStatus,
       FetchLKGR,
       CheckLastPush,
       PushToTrunk,
     ]
 
 
 if __name__ == "__main__":  # pragma: no cover
-  sys.exit(AutoRoll(CONFIG).Run())
+  sys.exit(AutoPush(CONFIG).Run())