MSE: Lift timestampOffset and appendWindow[Start,End] storage to WebSourceBufferImpl

MSE: Lift timestampOffset and appendWindow[Start,End] storage to WebSourceBufferImpl

Lifts timestamp offset and append window variables out of SourceState in
preparation for the upcoming refactoring of coded frame processing out
of SourceState.

R=acolwell@chromium.org
BUG=249422
TEST=All media_unittests and http/tests/media layout tests pass locally on Linux

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256509

[wolenetz, 2014-03-11 23:21:33]

Please take a look. This CL corresponds to your offline request to split this
"lifting" out of the LegacyFrameProcessor refactoring CL's patch set 3 @
https://codereview.chromium.org/191513002/#ps20001.

I believe I have addressed the comments you had relative to the pieces of this
prerequisite CL from patch set 3 of that other one.

https://codereview.chromium.org/196173002/diff/1/media/filters/chunk_demuxer_...
File media/filters/chunk_demuxer_unittest.cc (right):

https://codereview.chromium.org/196173002/diff/1/media/filters/chunk_demuxer_...
media/filters/chunk_demuxer_unittest.cc:964: base::TimeDelta
append_window_end_for_next_append_;
Note, I didn't see much gain by adding similar map for the append window bounds
per each source id. If we use non-default bounds more often, adding it would
make sense. The default constructor value for base::TimeDelta would also need to
be overwritten on append_window_end_map_[id] retrieval miss to be
kInfiniteDuration(), too.

[acolwell GONE FROM CHROMIUM, 2014-03-11 23:51:28]

lgtm

https://codereview.chromium.org/196173002/diff/1/media/filters/chunk_demuxer.cc
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/196173002/diff/1/media/filters/chunk_demuxer....
media/filters/chunk_demuxer.cc:631: base::TimeDelta timestamp_offset =
*timestamp_offset_during_append_;
nit: drop base::

[wolenetz, 2014-03-12 00:02:31]

Thanks. I'll send PS2 to CQ shortly.

https://codereview.chromium.org/196173002/diff/1/media/filters/chunk_demuxer.cc
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/196173002/diff/1/media/filters/chunk_demuxer....
media/filters/chunk_demuxer.cc:631: base::TimeDelta timestamp_offset =
*timestamp_offset_during_append_;
On 2014/03/11 23:51:29, acolwell wrote:
> nit: drop base::

Done (fixed here and in a few other places in this file).

[wolenetz, 2014-03-12 00:02:42]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2014-03-12 00:05:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wolenetz@chromium.org/196173002/20001

[commit-bot: I haz the power, 2014-03-12 10:22:44]

Change committed as 256509