Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 19617005: Define iTunes location for media galleries tests. (Closed)

Created:
7 years, 5 months ago by vandebo (ex-Chrome)
Modified:
7 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, vandebo (ex-Chrome), Lei Zhang, tzik+watch_chromium.org, tommycli, Greg Billock, kinuko+watch
Visibility:
Public.

Description

Define iTunes location for media galleries tests. BUG=NONE

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : checkpoint #

Patch Set 4 : compile #

Patch Set 5 : Null ptr #

Total comments: 4

Patch Set 6 : Comments #

Patch Set 7 : Compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -8 lines) Patch
M chrome/browser/media_galleries/fileapi/itunes_finder_mac.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_finder_mac.mm View 1 2 3 4 5 6 1 chunk +31 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_test_util.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_test_util.cc View 1 2 3 4 5 6 3 chunks +24 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vandebo (ex-Chrome)
7 years, 4 months ago (2013-08-12 23:20:10 UTC) #1
Lei Zhang
7 years, 4 months ago (2013-08-13 20:02:34 UTC) #2
https://codereview.chromium.org/19617005/diff/34001/chrome/browser/media_gall...
File chrome/browser/media_galleries/fileapi/itunes_finder_mac.h (right):

https://codereview.chromium.org/19617005/diff/34001/chrome/browser/media_gall...
chrome/browser/media_galleries/fileapi/itunes_finder_mac.h:19: static void
SetMacPreferencesForTesting(MacPreferences* preferences);
make |preferences| a scoped_ptr, so it's obvious it's taking ownership?

https://codereview.chromium.org/19617005/diff/34001/chrome/browser/media_gall...
File chrome/browser/media_galleries/fileapi/itunes_finder_mac.mm (right):

https://codereview.chromium.org/19617005/diff/34001/chrome/browser/media_gall...
chrome/browser/media_galleries/fileapi/itunes_finder_mac.mm:48: if
(g_mac_preferences)
delete does this check already.

https://codereview.chromium.org/19617005/diff/34001/chrome/browser/media_gall...
File chrome/browser/media_galleries/media_galleries_test_util.cc (right):

https://codereview.chromium.org/19617005/diff/34001/chrome/browser/media_gall...
chrome/browser/media_galleries/media_galleries_test_util.cc:107:
&kCFTypeArrayCallBacks);
I have no idea if this is right. Care to ask someone who knows mac code?

https://codereview.chromium.org/19617005/diff/34001/chrome/browser/media_gall...
chrome/browser/media_galleries/media_galleries_test_util.cc:108:
prefs->AddTestItem(CFSTR("iTunesRecentDatabasePaths"), array, false);
Can we make "iTunesRecentDatabasePaths" a const?

Powered by Google App Engine
This is Rietveld 408576698