Avoid unneeded RoundedInnerRectClipper rect clips

Avoid unneeded RoundedInnerRectClipper rect clips

ClipDisplayItem always applies a rectangular clip, and optionally a
list of rounded-rect clips.

As its client, RoundedInnerRectClipper is only interested in
applying the rounded-rect clips - so it passes a synthetic
"infinite" rect clip.  This clip is pure overhead.

Updated ClipDisplayItem to detect and ignore this clip.  While the
hood's up, remove the explicit FloatRoundedRect -> SkRRect conversion
(FloatRoundedRect already implements a SkRRect conversion operator).

This yields a ~23% improvement for Animometer/CSS Bouncing Gradient
Circles, in software mode only (no change for Ganesh).

BUG=603966
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/bef2b571b0d6d9571876f88341f47b350af3f6ce
Cr-Commit-Position: refs/heads/master@{#392734}

[f(malita), 2016-05-07 23:49:15]

Description was changed from

==========
Avoid unneeded infinite clips

WIP

BUG=
==========

to

==========
Avoid unneeded infinite clips

WIP

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[f(malita), 2016-05-08 01:38:30]

Description was changed from

==========
Avoid unneeded infinite clips

WIP

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Avoid unneeded RoundedInnerRectClipper rect clips 

ClipDisplayItem always applies a rectangular clip, and optionally a
list of rounded-rect clips.

As its client, RoundedInnerRectClipper is only interested in
applying the rounded-rect clips - so it passes a synthetic
"infinite" rect clip.  This clip is pure overhead.

Updated ClipDisplayItem to detect and ignore this clip.

This yields a ~23% improvement for Animometer/CSS Bouncing Gradient
Circles, in software mode only (no change for Ganesh).

BUG=603966
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[f(malita), 2016-05-08 01:38:30]

fmalita@chromium.org changed reviewers:
+ chrishtr@chromium.org

[f(malita), 2016-05-08 01:40:42]

Description was changed from

==========
Avoid unneeded RoundedInnerRectClipper rect clips 

ClipDisplayItem always applies a rectangular clip, and optionally a
list of rounded-rect clips.

As its client, RoundedInnerRectClipper is only interested in
applying the rounded-rect clips - so it passes a synthetic
"infinite" rect clip.  This clip is pure overhead.

Updated ClipDisplayItem to detect and ignore this clip.

This yields a ~23% improvement for Animometer/CSS Bouncing Gradient
Circles, in software mode only (no change for Ganesh).

BUG=603966
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Avoid unneeded RoundedInnerRectClipper rect clips 

ClipDisplayItem always applies a rectangular clip, and optionally a
list of rounded-rect clips.

As its client, RoundedInnerRectClipper is only interested in
applying the rounded-rect clips - so it passes a synthetic
"infinite" rect clip.  This clip is pure overhead.

Updated ClipDisplayItem to detect and ignore this clip.  While the
hood's up, remove the explicit FloatRoundedRect -> SkRRect conversion
(FloatRoundedRect already implements a SkRRect conversion operator).

This yields a ~23% improvement for Animometer/CSS Bouncing Gradient
Circles, in software mode only (no change for Ganesh).

BUG=603966
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[f(malita), 2016-05-08 02:00:15]

This works, but feels like a hacky/narrow optimization.

I think a better approach would be for RoundedInnerRectClipper to use a
different display item (generalize FloatClipDisplayItem to handle rounded-rects
and use that instead?).  I can look at it in a follow up, but maybe we can land
as-is to push the Animometer numbers forward.

[chrishtr, 2016-05-10 18:19:19]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-05-10 18:19:20]

lgtm

[commit-bot: I haz the power, 2016-05-10 18:20:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1961693002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1961693002/20001

[commit-bot: I haz the power, 2016-05-10 21:48:32]

Description was changed from

==========
Avoid unneeded RoundedInnerRectClipper rect clips 

ClipDisplayItem always applies a rectangular clip, and optionally a
list of rounded-rect clips.

As its client, RoundedInnerRectClipper is only interested in
applying the rounded-rect clips - so it passes a synthetic
"infinite" rect clip.  This clip is pure overhead.

Updated ClipDisplayItem to detect and ignore this clip.  While the
hood's up, remove the explicit FloatRoundedRect -> SkRRect conversion
(FloatRoundedRect already implements a SkRRect conversion operator).

This yields a ~23% improvement for Animometer/CSS Bouncing Gradient
Circles, in software mode only (no change for Ganesh).

BUG=603966
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Avoid unneeded RoundedInnerRectClipper rect clips 

ClipDisplayItem always applies a rectangular clip, and optionally a
list of rounded-rect clips.

As its client, RoundedInnerRectClipper is only interested in
applying the rounded-rect clips - so it passes a synthetic
"infinite" rect clip.  This clip is pure overhead.

Updated ClipDisplayItem to detect and ignore this clip.  While the
hood's up, remove the explicit FloatRoundedRect -> SkRRect conversion
(FloatRoundedRect already implements a SkRRect conversion operator).

This yields a ~23% improvement for Animometer/CSS Bouncing Gradient
Circles, in software mode only (no change for Ganesh).

BUG=603966
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-10 21:48:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 21:50:16]

Description was changed from

==========
Avoid unneeded RoundedInnerRectClipper rect clips 

ClipDisplayItem always applies a rectangular clip, and optionally a
list of rounded-rect clips.

As its client, RoundedInnerRectClipper is only interested in
applying the rounded-rect clips - so it passes a synthetic
"infinite" rect clip.  This clip is pure overhead.

Updated ClipDisplayItem to detect and ignore this clip.  While the
hood's up, remove the explicit FloatRoundedRect -> SkRRect conversion
(FloatRoundedRect already implements a SkRRect conversion operator).

This yields a ~23% improvement for Animometer/CSS Bouncing Gradient
Circles, in software mode only (no change for Ganesh).

BUG=603966
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Avoid unneeded RoundedInnerRectClipper rect clips

ClipDisplayItem always applies a rectangular clip, and optionally a
list of rounded-rect clips.

As its client, RoundedInnerRectClipper is only interested in
applying the rounded-rect clips - so it passes a synthetic
"infinite" rect clip.  This clip is pure overhead.

Updated ClipDisplayItem to detect and ignore this clip.  While the
hood's up, remove the explicit FloatRoundedRect -> SkRRect conversion
(FloatRoundedRect already implements a SkRRect conversion operator).

This yields a ~23% improvement for Animometer/CSS Bouncing Gradient
Circles, in software mode only (no change for Ganesh).

BUG=603966
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/bef2b571b0d6d9571876f88341f47b350af3f6ce
Cr-Commit-Position: refs/heads/master@{#392734}
==========

[commit-bot: I haz the power, 2016-05-10 21:50:17]

Patchset 2 (id:??) landed as
https://crrev.com/bef2b571b0d6d9571876f88341f47b350af3f6ce
Cr-Commit-Position: refs/heads/master@{#392734}