Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 19616005: Exclude 32-bit specific files from Win64 build (Closed)

Created:
7 years, 5 months ago by jschuh
Modified:
7 years, 5 months ago
Reviewers:
gab, kerz_chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 9 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jschuh
This is pretty much mechanical. Just excluding the files that don't get built on Win64 ...
7 years, 5 months ago (2013-07-19 17:49:43 UTC) #1
gab
lgtm
7 years, 5 months ago (2013-07-19 18:24:30 UTC) #2
gab
But please note that I am not the OWNER for FILES.cfg kerz and mmoss are. ...
7 years, 5 months ago (2013-07-19 18:25:53 UTC) #3
jschuh
On 2013/07/19 18:25:53, gab wrote: > But please note that I am not the OWNER ...
7 years, 5 months ago (2013-07-19 18:35:04 UTC) #4
kerz_chromium
On 2013/07/19 18:35:04, Justin Schuh wrote: > On 2013/07/19 18:25:53, gab wrote: > > But ...
7 years, 5 months ago (2013-07-19 18:40:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/19616005/1
7 years, 5 months ago (2013-07-19 18:49:41 UTC) #6
jschuh
7 years, 5 months ago (2013-07-19 22:24:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r212673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698