chrome/test/base/testing_profile.h - Issue 19616004: Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/testing_profile.h

Issue 19616004: Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Propigate CreateHistoryService return value properly Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_remover_unittest.cc ('K') | « chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc ('k') | chrome/test/base/testing_profile.cc » ('j') | chrome/test/base/testing_profile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/testing_profile.h

diff --git a/chrome/test/base/testing_profile.h b/chrome/test/base/testing_profile.h

index 916bc33dc3398b630a704f364096e327096fcef0..dd8d68ec2647ac4dc5105f08ade94f1a90a92019 100644

--- a/chrome/test/base/testing_profile.h

+++ b/chrome/test/base/testing_profile.h

@@ -132,8 +132,8 @@ class TestingProfile : public Profile {

// deletes the directory containing the files used by HistoryService, this

// only matters if you're recreating the HistoryService. If |no_db| is true,

// the history backend will fail to initialize its database; this is useful

- // for testing error conditions.

- void CreateHistoryService(bool delete_file, bool no_db);

+ // for testing error conditions. Returns true on success.

+ bool CreateHistoryService(bool delete_file, bool no_db) WARN_UNUSED_RESULT;

// Shuts down and nulls out the reference to HistoryService.

void DestroyHistoryService();