chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc - Issue 19616004: Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc

Issue 19616004: Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Propigate CreateHistoryService return value properly Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_remover_unittest.cc ('K') | « chrome/browser/search_engines/template_url_service_unittest.cc ('k') | chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc » ('j') | chrome/test/base/testing_profile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc

index fa79f1b371e14936faef707fce02ffce6cb434e8..169f451bca0450717f6706db4b6ca9436cf834f4 100644

--- a/chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_prompt_controller_unittest.cc

@@ -65,8 +65,8 @@ class BookmarkPromptControllerTest : public BrowserWithTestWindowTest {

TestingBrowserProcess::GetGlobal()->

SetBookmarkPromptController(new BookmarkPromptController);

BrowserWithTestWindowTest::SetUp();

- static_cast<TestingProfile*>(browser()->profile())->

- CreateHistoryService(true, false);

+ ASSERT_TRUE(static_cast<TestingProfile*>(browser()->profile())->

+ CreateHistoryService(true, false));

static_cast<TestingProfile*>(browser()->profile())->

BlockUntilHistoryIndexIsRefreshed();

// Simulate browser activation.