chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc - Issue 19616004: Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

Issue 19616004: Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Propigate CreateHistoryService return value properly Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_remover_unittest.cc ('K') | « chrome/browser/profiles/profile_manager_unittest.cc ('k') | chrome/browser/safe_browsing/malware_details_unittest.cc » ('j') | chrome/test/base/testing_profile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

diff --git a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

index dce0cf5f289adeb87713f9c411b6eb8dea2bb178..c54c71cdc65c8580f3aa81ea93dcb49b5dc1e1e9 100644

--- a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

+++ b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

@@ -51,7 +51,8 @@ class BrowserFeatureExtractorTest : public ChromeRenderViewHostTestHarness {

protected:

virtual void SetUp() {

ChromeRenderViewHostTestHarness::SetUp();

- profile()->CreateHistoryService(true /* delete_file */, false /* no_db */);

+ ASSERT_TRUE(profile()->CreateHistoryService(

+ true /* delete_file */, false /* no_db */));

service_.reset(new StrictMock<MockClientSideDetectionService>());

extractor_.reset(

new BrowserFeatureExtractor(web_contents(), service_.get()));