Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted

chrome/test/base/testing_profile.h

Index: chrome/test/base/testing_profile.h
diff --git a/chrome/test/base/testing_profile.h b/chrome/test/base/testing_profile.h
index 916bc33dc3398b630a704f364096e327096fcef0..348f3f86bc33736bbc3f72d591190bbada3e2e57 100644
--- a/chrome/test/base/testing_profile.h
+++ b/chrome/test/base/testing_profile.h
@@ -132,8 +132,8 @@ class TestingProfile : public Profile {
   // deletes the directory containing the files used by HistoryService, this
   // only matters if you're recreating the HistoryService.  If |no_db| is true,
   // the history backend will fail to initialize its database; this is useful
-  // for testing error conditions.
-  void CreateHistoryService(bool delete_file, bool no_db);
+  // for testing error conditions. Returns true on success.
+  bool CreateHistoryService(bool delete_file, bool no_db);

[sky, 2013/07/22 18:26:27]

Can you add WARN_UNUSED_RESULT?

[rmcilroy, 2013/07/22 22:44:17]

Done, and fixed all callers to assert on this being true.

 
   // Shuts down and nulls out the reference to HistoryService.
   void DestroyHistoryService();