Add asserts to TestingProfile::CreateHistoryService to ensure files are deleted

chrome/test/base/testing_profile.cc

Index: chrome/test/base/testing_profile.cc
diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc
index e35899875925ed2d5b97e524fe9524cd83d342be..fd24593ebe4b992c3b9d1eb5326a3e79a3961bee 100644
--- a/chrome/test/base/testing_profile.cc
+++ b/chrome/test/base/testing_profile.cc
@@ -359,7 +359,8 @@ void TestingProfile::CreateHistoryService(bool delete_file, bool no_db) {
   if (delete_file) {
     base::FilePath path = GetPath();
     path = path.Append(chrome::kHistoryFilename);
-    base::DeleteFile(path, false);
+    ASSERT_TRUE(base::DeleteFile(path, false));

[sky, 2013/07/19 20:04:57]

In general you shouldn't use ASSERTS in tests. It makes the whole harness crash
and no further tests are run.

[rmcilroy, 2013/07/22 11:18:07]

Changed these to EXPECTS (I thought ASSERTS were allowed in setup-type code, but
am fine with these being EXPECTS in either case).

+    ASSERT_FALSE(base::PathExists(path));
   }
   // This will create and init the history service.
   HistoryService* history_service = static_cast<HistoryService*>(