Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: net/spdy/spdy_session.cc

Issue 1961573002: Avoids the "re-encode HPACK as SPDY3" step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update new test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session.h ('k') | net/spdy/spdy_test_util_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index aa78dcf8dd84a0cc28513fd759c25dda244ca260..daa1208452bcb328550cef5a7ea8ac7a7d76611a 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -361,6 +361,8 @@ SpdyProtocolErrorDetails MapFramerErrorToProtocolError(
return SPDY_ERROR_INVALID_CONTROL_FRAME_FLAGS;
case SpdyFramer::SPDY_UNEXPECTED_FRAME:
return SPDY_ERROR_UNEXPECTED_FRAME;
+ case SpdyFramer::SPDY_INTERNAL_FRAMER_ERROR:
+ return SPDY_ERROR_INTERNAL_FRAMER_ERROR;
case SpdyFramer::SPDY_INVALID_CONTROL_FRAME_SIZE:
return SPDY_ERROR_INVALID_CONTROL_FRAME_SIZE;
case SpdyFramer::SPDY_INVALID_STREAM_ID:
@@ -399,6 +401,8 @@ Error MapFramerErrorToNetError(SpdyFramer::SpdyError err) {
return ERR_SPDY_PROTOCOL_ERROR;
case SpdyFramer::SPDY_UNEXPECTED_FRAME:
return ERR_SPDY_PROTOCOL_ERROR;
+ case SpdyFramer::SPDY_INTERNAL_FRAMER_ERROR:
+ return ERR_SPDY_PROTOCOL_ERROR;
case SpdyFramer::SPDY_INVALID_CONTROL_FRAME_SIZE:
return ERR_SPDY_FRAME_SIZE_ERROR;
case SpdyFramer::SPDY_INVALID_STREAM_ID:
@@ -2207,16 +2211,6 @@ void SpdySession::OnStreamPadding(SpdyStreamId stream_id, size_t len) {
it->second.stream->OnPaddingConsumed(len);
}
-SpdyHeadersHandlerInterface* SpdySession::OnHeaderFrameStart(
- SpdyStreamId stream_id) {
- LOG(FATAL);
- return nullptr;
-}
-
-void SpdySession::OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) {
- LOG(FATAL);
-}
-
void SpdySession::OnSettings(bool clear_persisted) {
CHECK(in_io_loop_);
« no previous file with comments | « net/spdy/spdy_session.h ('k') | net/spdy/spdy_test_util_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698