Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: net/http/bidirectional_stream_unittest.cc

Issue 1961573002: Avoids the "re-encode HPACK as SPDY3" step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avoids the "re-encode HPACK as SPDY3" step. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/net.gypi » ('j') | net/spdy/header_coalescer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/bidirectional_stream_unittest.cc
diff --git a/net/http/bidirectional_stream_unittest.cc b/net/http/bidirectional_stream_unittest.cc
index 2b295361ca6db9f77d78f4d276e5b51c88abc8ab..07177a81504dc75fd24015a7a9ea0d77c564e3b3 100644
--- a/net/http/bidirectional_stream_unittest.cc
+++ b/net/http/bidirectional_stream_unittest.cc
@@ -1195,8 +1195,7 @@ TEST_F(BidirectionalStreamTest, PropagateProtocolError) {
// BidirectionalStreamSpdyStreamJob does not count the bytes sent for |rst|
// because it is sent after SpdyStream::Delegate::OnClose is called.
EXPECT_EQ(CountWriteBytes(writes, 1), delegate->GetTotalSentBytes());
- EXPECT_EQ(CountReadBytes(reads, arraysize(reads)),
- delegate->GetTotalReceivedBytes());
+ EXPECT_EQ(0, delegate->GetTotalReceivedBytes());
Ryan Hamilton 2016/05/13 22:03:15 Can you explain why this expectation is changing?
dahollings 2016/05/16 22:00:17 The coalescer (new file) was catching the invalid
}
INSTANTIATE_TEST_CASE_P(CancelOrDeleteTests,
« no previous file with comments | « no previous file | net/net.gypi » ('j') | net/spdy/header_coalescer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698