Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: net/spdy/buffered_spdy_framer_unittest.cc

Issue 1961573002: Avoids the "re-encode HPACK as SPDY3" step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update new test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/header_coalescer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/buffered_spdy_framer.h" 5 #include "net/spdy/buffered_spdy_framer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "net/spdy/spdy_test_util_common.h" 8 #include "net/spdy/spdy_test_util_common.h"
9 #include "testing/platform_test.h" 9 #include "testing/platform_test.h"
10 10
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 } 85 }
86 86
87 void OnStreamEnd(SpdyStreamId stream_id) override { 87 void OnStreamEnd(SpdyStreamId stream_id) override {
88 LOG(FATAL) << "Unexpected OnStreamEnd call."; 88 LOG(FATAL) << "Unexpected OnStreamEnd call.";
89 } 89 }
90 90
91 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override { 91 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {
92 LOG(FATAL) << "Unexpected OnStreamPadding call."; 92 LOG(FATAL) << "Unexpected OnStreamPadding call.";
93 } 93 }
94 94
95 SpdyHeadersHandlerInterface* OnHeaderFrameStart(
96 SpdyStreamId stream_id) override {
97 LOG(FATAL) << "Unexpected OnHeaderFrameStart call.";
98 return nullptr;
99 }
100
101 void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) override {
102 LOG(FATAL) << "Unexpected OnHeaderFrameEnd call.";
103 }
104
105 void OnSettings(bool clear_persisted) override {} 95 void OnSettings(bool clear_persisted) override {}
106 96
107 void OnSetting(SpdySettingsIds id, uint8_t flags, uint32_t value) override { 97 void OnSetting(SpdySettingsIds id, uint8_t flags, uint32_t value) override {
108 setting_count_++; 98 setting_count_++;
109 } 99 }
110 100
111 void OnPing(SpdyPingId unique_id, bool is_ack) override {} 101 void OnPing(SpdyPingId unique_id, bool is_ack) override {}
112 102
113 void OnRstStream(SpdyStreamId stream_id, 103 void OnRstStream(SpdyStreamId stream_id,
114 SpdyRstStreamStatus status) override {} 104 SpdyRstStreamStatus status) override {}
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 reinterpret_cast<unsigned char*>(goaway_frame.get()->data()), 332 reinterpret_cast<unsigned char*>(goaway_frame.get()->data()),
343 goaway_frame.get()->size()); 333 goaway_frame.get()->size());
344 EXPECT_EQ(0, visitor.error_count_); 334 EXPECT_EQ(0, visitor.error_count_);
345 EXPECT_EQ(1, visitor.goaway_count_); 335 EXPECT_EQ(1, visitor.goaway_count_);
346 EXPECT_EQ(2u, visitor.goaway_last_accepted_stream_id_); 336 EXPECT_EQ(2u, visitor.goaway_last_accepted_stream_id_);
347 EXPECT_EQ(GOAWAY_FRAME_SIZE_ERROR, visitor.goaway_status_); 337 EXPECT_EQ(GOAWAY_FRAME_SIZE_ERROR, visitor.goaway_status_);
348 EXPECT_EQ("foo", visitor.goaway_debug_data_); 338 EXPECT_EQ("foo", visitor.goaway_debug_data_);
349 } 339 }
350 340
351 } // namespace net 341 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/buffered_spdy_framer.cc ('k') | net/spdy/header_coalescer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698