Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1961553002:
cc: optimize color matrix application for more complex filter DAGs. (Closed)
|
Created:
4 years, 7 months ago by Stephen White Modified:
4 years, 7 months ago Reviewers:
enne (OOO) CC:
chromium-reviews, cc-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncc: optimize color matrix application for more complex filter DAGs.
We previously optimized the case where a filter DAG consisted of a
single SkColorFilterImageFilter containing an SkColorMatrixFilter.
Here we extend it to support any DAG with such a filter at its root,
call skia to process the rest of the DAG, and apply the matrix in cc's
RenderSurface draw pass.
BUG=609897
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/d0f2f2751803999b3b9b8cc04bf4628db67cf011
Cr-Commit-Position: refs/heads/master@{#392134}
Patch Set 1 #Patch Set 2 : Fix comment #Messages
Total messages: 18 (9 generated)
Description was changed from ========== cc: optimize color matrix application for more complex DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 ========== to ========== cc: optimize color matrix application for more complex DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: optimize color matrix application for more complex DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: optimize color matrix application for more complex DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
senorblanco@chromium.org changed reviewers: + enne@chromium.org
enne: PTAL. Thanks!
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961553002/20001
Description was changed from ========== cc: optimize color matrix application for more complex DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: optimize color matrix application for more complex filter DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkColorMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Pixel test? <_<
On 2016/05/06 18:26:29, enne wrote: > Pixel test? <_< RotatedFilterTest should cover it, since it has a brightness followed by a grayscale.
Oh, great! lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by senorblanco@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961553002/20001
Message was sent while issue was closed.
Description was changed from ========== cc: optimize color matrix application for more complex filter DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkColorMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: optimize color matrix application for more complex filter DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkColorMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== cc: optimize color matrix application for more complex filter DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkColorMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: optimize color matrix application for more complex filter DAGs. We previously optimized the case where a filter DAG consisted of a single SkColorFilterImageFilter containing an SkColorMatrixFilter. Here we extend it to support any DAG with such a filter at its root, call skia to process the rest of the DAG, and apply the matrix in cc's RenderSurface draw pass. BUG=609897 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d0f2f2751803999b3b9b8cc04bf4628db67cf011 Cr-Commit-Position: refs/heads/master@{#392134} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d0f2f2751803999b3b9b8cc04bf4628db67cf011 Cr-Commit-Position: refs/heads/master@{#392134} |
