Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1961493002: Add two missing base tests to gn build (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Alexei Svitkine (slow), petrcermak
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add two missing base tests to gn build BUG=604060 Committed: https://crrev.com/443e67e3f6f3037c3c97ccc1dc3fa2e501bfdb15 Cr-Commit-Position: refs/heads/master@{#392405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
These two test files are compiled in gyp builds but not gn builds, which is ...
4 years, 7 months ago (2016-05-06 14:27:44 UTC) #2
Lei Zhang
lgtm Several people, including myself, forgot base/ GYP file list changes do not get automatically ...
4 years, 7 months ago (2016-05-09 18:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961493002/1
4 years, 7 months ago (2016-05-09 18:58:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 20:02:10 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 20:03:50 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/443e67e3f6f3037c3c97ccc1dc3fa2e501bfdb15
Cr-Commit-Position: refs/heads/master@{#392405}

Powered by Google App Engine
This is Rietveld 408576698