Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1961483002: Revert of Disable layer hoisting for non-8888 canvases (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Disable layer hoisting for non-8888 canvases (patchset #2 id:20001 of https://codereview.chromium.org/1957433002/ ) Reason for revert: Experimental revert to investigate perf regression Original issue's description: > Disable layer hoisting for non-8888 canvases > > This just stops the bleeding. A real fix would propagate the canvas' backing type down to the layer hoister. > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957433002 > > Committed: https://skia.googlesource.com/skia/+/4e30f27164179d344f0c8efa9a691d1bc9a53e3f TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/6b53b9daeb2137a91d8ddb8e890d66c702bfbaa3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/core/SkMultiPictureDraw.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
robertphillips
Created Revert of Disable layer hoisting for non-8888 canvases
4 years, 7 months ago (2016-05-06 14:16:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961483002/1
4 years, 7 months ago (2016-05-06 14:16:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6b53b9daeb2137a91d8ddb8e890d66c702bfbaa3
4 years, 7 months ago (2016-05-06 14:16:25 UTC) #4
bsalomon
lgtm
4 years, 7 months ago (2016-05-06 14:16:41 UTC) #5
robertphillips
4 years, 7 months ago (2016-05-09 11:49:38 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1962603002/ by robertphillips@google.com.

The reason for reverting is: This CL was not the culprit in the perf
regression..

Powered by Google App Engine
This is Rietveld 408576698