Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3179)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/BUILD.gn

Issue 1961473003: [Mac/GN] Set up the component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn » ('j') | build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index c5e5e75e89955f117d174ae84994e802082fdac8..76bb3a65bd094f8433b28fbd490e723f7b994740 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1528,6 +1528,10 @@ component("i18n") {
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
+ if (is_mac) {
+ libs = [ "CoreFoundation.framework" ]
+ }
}
test("base_perftests") {
« no previous file with comments | « no previous file | build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn » ('j') | build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698