Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: tools/perf/chrome_telemetry_build/BUILD.gn

Issue 1961473003: [Mac/GN] Set up the component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/chrome_telemetry_build/BUILD.gn
diff --git a/tools/perf/chrome_telemetry_build/BUILD.gn b/tools/perf/chrome_telemetry_build/BUILD.gn
index 5c7b2c5a8e669d333a5f5fef1617ac35d51c13cb..332a44c5f66309177cbb79cf85d721678d055b4c 100644
--- a/tools/perf/chrome_telemetry_build/BUILD.gn
+++ b/tools/perf/chrome_telemetry_build/BUILD.gn
@@ -32,11 +32,16 @@ group("telemetry_chrome_test") {
]
} else {
data_deps = [
- # TODO(kbr): this used to be "//chrome". Had to change this to
- # chrome_initial temporarily to work around crbug.com/536192.
- "//chrome:chrome_initial",
"//third_party/catapult/telemetry:bitmaptools",
]
+
+ if (!is_mac) {
+ # TODO(kbr): this used to be "//chrome". Had to change this to
+ # chrome_initial temporarily to work around crbug.com/536192.
+ data_deps += [ "//chrome:chrome_initial" ]
+ } else {
+ data_deps += [ "//chrome" ]
+ }
Dirk Pranke 2016/05/06 22:10:07 I think this bug/workaround has been fixed and we
Robert Sesek 2016/05/06 22:20:49 Yeah, I figured this would be better to handle in
}
data = [

Powered by Google App Engine
This is Rietveld 408576698