Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gin/BUILD.gn

Issue 1961473003: [Mac/GN] Set up the component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/BUILD.gn ('K') | « device/bluetooth/BUILD.gn ('k') | gpu/config/BUILD.gn » ('j') | media/base/mac/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/BUILD.gn
diff --git a/gin/BUILD.gn b/gin/BUILD.gn
index c0adbc9907ae6aaff3db33aa4c2241efcff99eee..4da04284e3f69845f17428ae65d45b656bab758f 100644
--- a/gin/BUILD.gn
+++ b/gin/BUILD.gn
@@ -92,6 +92,10 @@ component("gin") {
defines += [ "V8_VERIFY_EXTERNAL_STARTUP_DATA" ]
}
+ if (is_mac) {
+ libs = [ "CoreFoundation.framework" ]
+ }
+
configs += [ "//v8:external_startup_data" ]
}
« chrome/BUILD.gn ('K') | « device/bluetooth/BUILD.gn ('k') | gpu/config/BUILD.gn » ('j') | media/base/mac/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698