Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: media/base/mac/BUILD.gn

Issue 1961473003: [Mac/GN] Set up the component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment and rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/BUILD.gn ('k') | media/capture/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mac/BUILD.gn
diff --git a/media/base/mac/BUILD.gn b/media/base/mac/BUILD.gn
index 95540d6890ff462f3ff4911308669a0e501a5a35..08e0560fb61caa129acf104b1b5a538b4a3a43f5 100644
--- a/media/base/mac/BUILD.gn
+++ b/media/base/mac/BUILD.gn
@@ -5,6 +5,12 @@
assert(is_mac || is_ios)
source_set("mac") {
+ # Note: This source_set is depended on only by //media. In the component
+ # build, if other component targets also depend on it, multiple copies of
+ # the ObjC classes declared in the files below will cause warnings at
+ # run-time.
+ visibility = [ "//media" ]
+
set_sources_assignment_filter([])
sources = [
"coremedia_glue.h",
@@ -24,13 +30,14 @@ source_set("mac") {
]
libs = [
"AVFoundation.framework",
-
- # Required by video_frame_mac.cc.
- "CoreVideo.framework",
+ "CoreVideo.framework", # Required by video_frame_mac.cc.
]
}
set_sources_assignment_filter(sources_assignment_filter)
- configs += [ "//media:media_config" ]
+ configs += [
+ "//media:media_config",
+ "//media:media_implementation",
+ ]
}
source_set("unittests") {
« no previous file with comments | « media/BUILD.gn ('k') | media/capture/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698