Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: content/shell/BUILD.gn

Issue 1961473003: [Mac/GN] Set up the component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/BUILD.gn ('k') | crypto/BUILD.gn » ('j') | media/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index 9b7f85a2040cfe8184d73ca64ee3a17acf98301a..dd3733205eaa5c574aedf28aed67c35c45e05a58 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -621,10 +621,7 @@ if (is_mac) {
deps += [ ":content_shell_framework_plugins" ]
}
- ldflags = [
- "-install_name",
- "@executable_path/../Frameworks/$output_name.framework/$output_name",
- ]
+ ldflags = [ "-Wl,-install_name,@executable_path/../Frameworks/$output_name.framework/$output_name" ]
info_plist_target = ":content_shell_framework_plist"
}
@@ -650,6 +647,10 @@ if (is_mac) {
deps = [
":content_shell_framework+link",
]
+ ldflags = [
Nico 2016/05/10 20:24:06 want to add the comment here too?
Robert Sesek 2016/05/10 21:32:43 Done.
+ "-rpath",
+ "@loader_path/../../../../../..",
+ ]
info_plist_target = ":content_shell_helper_plist"
}
« no previous file with comments | « content/browser/BUILD.gn ('k') | crypto/BUILD.gn » ('j') | media/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698