Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1961463003: Detect an invalid intervalCount in SkRegion during deserialiation. (Closed)

Created:
3 years ago by Stephen White
Modified:
3 years ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/core/SkRegion.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961463003/1
3 years ago (2016-05-06 15:23:41 UTC) #5
Stephen White
Rob: PTAL. Thanks!
3 years ago (2016-05-06 15:23:51 UTC) #6
robertphillips
lgtm
3 years ago (2016-05-06 15:38:35 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years ago (2016-05-06 15:47:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961463003/1
3 years ago (2016-05-06 15:48:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/675576f023c8fa10cdb0c18bc0a6c214e0bab069
3 years ago (2016-05-06 15:49:00 UTC) #13
reed1
3 years ago (2016-05-06 17:00:25 UTC) #15
Message was sent while issue was closed.
1. comment why intervalCount of 1 is not valid?
2. comment why we don't check ySpanCount?
3. is it reasonable to create a unittest or fuzzer to exercise this?

Powered by Google App Engine
This is Rietveld 408576698