Issue 196145: Gears File Drag Drop...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196145: Gears File Drag Drop... (Closed)

Created:
11 years, 3 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
noel.gordon

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Gears File Drag Drop r24899 now keys the child security policy database based on renderer id, rather than renderer process id. Update gears drag drop to use the renderer id for the file policy access checks. This is a clone for submission of of noel's original CL http://codereview.chromium.org/195079 BUG=7995 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26397

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -26 lines)			Patch
M	chrome/browser/plugin_process_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_process_host.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/plugin_messages_internal.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/plugin/chrome_plugin_host.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/plugin/plugin_channel.h	View	4 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/plugin/plugin_channel.cc	View	1 chunk	+13 lines, -6 lines	0 comments	Download
M	chrome/plugin/plugin_thread.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/plugin/webplugin_proxy.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/plugin/webplugin_proxy.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM and thanks.