Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196143005: Stop using toParentMediaElement internally in MediaControlElements (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Stop using toParentMediaElement internally in MediaControlElements Just use mediaElement() BUG=341813 R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M Source/core/html/shadow/MediaControlElements.cpp View 4 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
philipj_slow
adamk, for you since acolwell is OOO
6 years, 9 months ago (2014-03-12 16:57:06 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-12 18:27:36 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-13 01:22:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/196143005/1
6 years, 9 months ago (2014-03-13 01:22:04 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 04:30:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_blink
6 years, 9 months ago (2014-03-13 04:30:20 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-13 05:35:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/196143005/1
6 years, 9 months ago (2014-03-13 05:35:25 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 07:04:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_blink
6 years, 9 months ago (2014-03-13 07:04:14 UTC) #10
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-13 07:05:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/196143005/1
6 years, 9 months ago (2014-03-13 07:05:58 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 08:17:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_blink
6 years, 9 months ago (2014-03-13 08:17:59 UTC) #14
philipj_slow
6 years, 9 months ago (2014-03-13 09:22:45 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 manually as r169107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698