Source/core/css/resolver/StyleAdjuster.cpp - Issue 196143004: Fix usage of pseudo style cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleAdjuster.cpp

Issue 196143004: Fix usage of pseudo style cache (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: check for cached pseudo style and mark pseudo styles with animations as unique Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleAdjuster.cpp

diff --git a/Source/core/css/resolver/StyleAdjuster.cpp b/Source/core/css/resolver/StyleAdjuster.cpp

index 47fd83541774507e96858d18e08d86f966806203..30abca47feec71c8bb0dfc37fc05af41e02d7e45 100644

--- a/Source/core/css/resolver/StyleAdjuster.cpp

+++ b/Source/core/css/resolver/StyleAdjuster.cpp

@@ -280,8 +280,8 @@ void StyleAdjuster::adjustRenderStyle(RenderStyle* style, RenderStyle* parentSty

if (style->hasAppearance())

RenderTheme::theme().adjustStyle(style, e, m_cachedUAStyle);

- // If we have first-letter pseudo style, do not share this style.

- if (style->hasPseudoStyle(FIRST_LETTER))

+ // If we have first-letter pseudo style, transitions, or animations, do not share this style.

+ if (style->hasPseudoStyle(FIRST_LETTER) || style->transitions() || style->animations())

style->setUnique();

// FIXME: when dropping the -webkit prefix on transform-style, we should also have opacity < 1 cause flattening.