Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: Source/core/rendering/style/RenderStyle.h

Issue 196143004: Fix usage of pseudo style cache (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: check for cached pseudo style and mark pseudo styles with animations as unique Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/resolver/StyleResolver.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1831 matching lines...) Expand 10 before | Expand all | Expand 10 after
1842 rareInheritedData.access()->m_effectiveZoom = f; 1842 rareInheritedData.access()->m_effectiveZoom = f;
1843 return true; 1843 return true;
1844 } 1844 }
1845 1845
1846 inline bool RenderStyle::isSharable() const 1846 inline bool RenderStyle::isSharable() const
1847 { 1847 {
1848 if (unique()) 1848 if (unique())
1849 return false; 1849 return false;
1850 if (hasUniquePseudoStyle()) 1850 if (hasUniquePseudoStyle())
1851 return false; 1851 return false;
1852 if (transitions() || animations())
1853 return false;
1854 return true; 1852 return true;
1855 } 1853 }
1856 1854
1857 inline bool RenderStyle::setTextOrientation(TextOrientation textOrientation) 1855 inline bool RenderStyle::setTextOrientation(TextOrientation textOrientation)
1858 { 1856 {
1859 if (compareEqual(rareInheritedData->m_textOrientation, textOrientation)) 1857 if (compareEqual(rareInheritedData->m_textOrientation, textOrientation))
1860 return false; 1858 return false;
1861 1859
1862 rareInheritedData.access()->m_textOrientation = textOrientation; 1860 rareInheritedData.access()->m_textOrientation = textOrientation;
1863 return true; 1861 return true;
(...skipping 21 matching lines...) Expand all
1885 inline bool RenderStyle::hasPseudoElementStyle() const 1883 inline bool RenderStyle::hasPseudoElementStyle() const
1886 { 1884 {
1887 return noninherited_flags._pseudoBits & PSEUDO_ELEMENT_MASK; 1885 return noninherited_flags._pseudoBits & PSEUDO_ELEMENT_MASK;
1888 } 1886 }
1889 1887
1890 float calcBorderRadiiConstraintScaleFor(const FloatRect&, const FloatRoundedRect ::Radii&); 1888 float calcBorderRadiiConstraintScaleFor(const FloatRect&, const FloatRoundedRect ::Radii&);
1891 1889
1892 } // namespace WebCore 1890 } // namespace WebCore
1893 1891
1894 #endif // RenderStyle_h 1892 #endif // RenderStyle_h
OLDNEW
« no previous file with comments | « Source/core/css/resolver/StyleResolver.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698