Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1961403002: Revert of [heap] Fine-grained JSArrayBuffer tracking (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Fine-grained JSArrayBuffer tracking (patchset #7 id:200001 of https://codereview.chromium.org/1936233002/ ) Reason for revert: Breaks readonly test https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux/builds/10121 Original issue's description: > [heap] Fine-grained JSArrayBuffer tracking > > Track based on JSArrayBuffer addresses instead of the attached backing store. > This way we can later on iterate buffers on a single page. > > BUG=chromium:581412 > LOG=N > R=jochen@chromium.org, hpayer@chromium.org > > Committed: https://crrev.com/4cdf71e2d07c038d7af84e41c6e6d0093af0f0de > Cr-Commit-Position: refs/heads/master@{#36140} TBR=hpayer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Committed: https://crrev.com/c0fe26d25325c3bef47ab70e0cbcae6f4f2d782c Cr-Commit-Position: refs/heads/master@{#36143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -361 lines) Patch
M src/heap/array-buffer-tracker.h View 2 chunks +25 lines, -50 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 3 chunks +64 lines, -103 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 4 chunks +3 lines, -14 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +1 line, -7 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +0 lines, -178 lines 0 comments Download
M test/cctest/heap/utils-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Lippautz
Created Revert of [heap] Fine-grained JSArrayBuffer tracking
4 years, 7 months ago (2016-05-10 13:29:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961403002/1
4 years, 7 months ago (2016-05-10 13:29:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 13:29:29 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 13:30:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0fe26d25325c3bef47ab70e0cbcae6f4f2d782c
Cr-Commit-Position: refs/heads/master@{#36143}

Powered by Google App Engine
This is Rietveld 408576698