runtime/vm/flow_graph_type_propagator.cc - Issue 1961393002: VM: Optimized code for all of [External]{One|Two}ByteString::codeUnitAt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 1961393002: VM: Optimized code for all of [External]{One|Two}ByteString::codeUnitAt. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: addressed comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index f95e6b28d07c4aa52c0a03bb45a31828719f9605..d0391dbf81c07e7854b186d95c119445ea8d3b5f 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -921,8 +921,8 @@ CompileType StoreLocalInstr::ComputeType() const {

}

-CompileType StringFromCharCodeInstr::ComputeType() const {

- return CompileType::FromCid(cid_);

+CompileType OneByteStringFromCharCodeInstr::ComputeType() const {

+ return CompileType::FromCid(kOneByteStringCid);

}

« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »