runtime/vm/constant_propagator.cc - Issue 1961393002: VM: Optimized code for all of [External]{One|Two}ByteString::codeUnitAt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constant_propagator.cc

Issue 1961393002: VM: Optimized code for all of [External]{One|Two}ByteString::codeUnitAt. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: addressed comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/constant_propagator.cc

diff --git a/runtime/vm/constant_propagator.cc b/runtime/vm/constant_propagator.cc

index 4176af4c1c40b2071ef7d68f766b63d660bc53a1..4409f3f274b783e9ed8cd91aa6babce1423402cb 100644

--- a/runtime/vm/constant_propagator.cc

+++ b/runtime/vm/constant_propagator.cc

@@ -604,8 +604,8 @@ void ConstantPropagator::VisitDebugStepCheck(DebugStepCheckInstr* instr) {

}

-void ConstantPropagator::VisitStringFromCharCode(

- StringFromCharCodeInstr* instr) {

+void ConstantPropagator::VisitOneByteStringFromCharCode(

+ OneByteStringFromCharCodeInstr* instr) {

const Object& o = instr->char_code()->definition()->constant_value();

if (o.IsNull() || IsNonConstant(o)) {

SetValue(instr, non_constant_);

« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »