VM: Optimized code for all of [External]{One|Two}ByteString::codeUnitAt.

runtime/vm/method_recognizer.h

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_METHOD_RECOGNIZER_H_
 #define VM_METHOD_RECOGNIZER_H_
 
 #include "vm/allocation.h"
 
 namespace dart {
@@ skipping 160 matching lines @@
   V(_Double, _mulFromInteger, Double_mulFromInteger, 1893886883)               \
   V(_Double, .fromInteger, DoubleFromInteger, 2129942595)                      \
   V(_List, []=, ObjectArraySetIndexed, 886228780)                              \
   V(_GrowableList, .withData, GrowableArray_Allocate, 631736030)               \
   V(_GrowableList, add, GrowableArray_add, 219371757)                          \
   V(_RegExp, _ExecuteMatch, RegExp_ExecuteMatch, 1614206970)                   \
   V(Object, ==, ObjectEquals, 291909336)                                       \
   V(Object, get:runtimeType, ObjectRuntimeType, 15188587)                      \
   V(_StringBase, get:hashCode, String_getHashCode, 2026040200)                 \
   V(_StringBase, get:isEmpty, StringBaseIsEmpty, 1958879178)                   \
-  V(_StringBase, codeUnitAt, StringBaseCodeUnitAt, 1436590579)                 \
   V(_StringBase, _substringMatches, StringBaseSubstringMatches, 797253099)     \
   V(_StringBase, [], StringBaseCharAt, 754527301)                              \
   V(_OneByteString, get:hashCode, OneByteString_getHashCode, 2026040200)       \
   V(_OneByteString, _substringUncheckedNative,                                 \
     OneByteString_substringUnchecked, 1670133538)                              \
   V(_OneByteString, _setAt, OneByteStringSetAt, 1160066031)                    \
   V(_OneByteString, _allocate, OneByteString_allocate, 1028631946)             \
   V(_OneByteString, ==, OneByteString_equality, 1062844160)                    \
   V(_TwoByteString, ==, TwoByteString_equality, 1062844160)                    \
 
@@ skipping 86 matching lines @@
   V(_List, [], ObjectArrayGetIndexed, 360400496)                               \
   V(_ImmutableList, get:length, ImmutableArrayLength, 630471378)               \
   V(_ImmutableList, [], ImmutableArrayGetIndexed, 360400496)                   \
   V(_GrowableList, get:length, GrowableArrayLength, 417111542)                 \
   V(_GrowableList, get:_capacity, GrowableArrayCapacity, 41110914)             \
   V(_GrowableList, _setData, GrowableArraySetData, 210059283)                  \
   V(_GrowableList, _setLength, GrowableArraySetLength, 335652822)              \
   V(_GrowableList, [], GrowableArrayGetIndexed, 1957529650)                    \
   V(_GrowableList, []=, GrowableArraySetIndexed, 225246870)                    \
   V(_StringBase, get:length, StringBaseLength, 707533587)                      \
+  V(_OneByteString, codeUnitAt, OneByteStringCodeUnitAt, 1436590579)           \
+  V(_TwoByteString, codeUnitAt, TwoByteStringCodeUnitAt, 1436590579)           \
+  V(_ExternalOneByteString, codeUnitAt, ExternalOneByteStringCodeUnitAt,       \
+    1436590579)                                                                \
+  V(_ExternalTwoByteString, codeUnitAt, ExternalTwoByteStringCodeUnitAt,       \
+    1436590579)                                                                \
   V(_Double, unary-, DoubleFlipSignBit, 1783281169)                            \
   V(_Double, truncateToDouble, DoubleTruncate, 791143891)                      \
   V(_Double, roundToDouble, DoubleRound, 797558034)                            \
   V(_Double, floorToDouble, DoubleFloor, 1789426271)                           \
   V(_Double, ceilToDouble, DoubleCeil, 453271198)                              \
   V(_Double, _modulo, DoubleMod, 776062204)
 
 
 #define GRAPH_INTRINSICS_LIST(V)                                               \
   GRAPH_CORE_INTRINSICS_LIST(V)                                                \
@@ skipping 147 matching lines @@
   V(_IntegerImplementation, ==, Integer_equal, 272474439)                      \
   V(_IntegerImplementation, <, Integer_lessThan, 652059836)                    \
   V(_IntegerImplementation, <=, Integer_lessEqualThan, 512138528)              \
   V(_IntegerImplementation, >=, Integer_greaterEqualThan, 1815180096)          \
   V(_IntegerImplementation, <<, Integer_shl, 1127538624)                       \
   V(_IntegerImplementation, >>, Integer_sar, 1243972513)                       \
 
 // A list of core functions that internally dispatch based on received id.
 #define POLYMORPHIC_TARGET_LIST(V)                                             \
   V(_StringBase, [], StringBaseCharAt, 754527301)                              \
-  V(_StringBase, codeUnitAt, StringBaseCodeUnitAt, 1436590579)                 \
   V(_TypedList, _getInt8, ByteArrayBaseGetInt8, 1508321565)                    \
   V(_TypedList, _getUint8, ByteArrayBaseGetUint8, 953411007)                   \
   V(_TypedList, _getInt16, ByteArrayBaseGetInt16, 433971756)                   \
   V(_TypedList, _getUint16, ByteArrayBaseGetUint16, 1329446488)                \
   V(_TypedList, _getInt32, ByteArrayBaseGetInt32, 137212209)                   \
   V(_TypedList, _getUint32, ByteArrayBaseGetUint32, 499907480)                 \
   V(_TypedList, _getFloat32, ByteArrayBaseGetFloat32, 1672834581)              \
   V(_TypedList, _getFloat64, ByteArrayBaseGetFloat64, 966634744)               \
   V(_TypedList, _getFloat32x4, ByteArrayBaseGetFloat32x4, 1197581758)          \
   V(_TypedList, _getInt32x4, ByteArrayBaseGetInt32x4, 810805548)               \
@@ skipping 66 matching lines @@
 // Class that recognizes factories and returns corresponding result cid.
 class FactoryRecognizer : public AllStatic {
  public:
   // Return kDynamicCid if factory is not recognized.
   static intptr_t ResultCid(const Function& factory);
 };
 
 }  // namespace dart
 
 #endif  // VM_METHOD_RECOGNIZER_H_