Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 196137: Improve tab-closability of right-most tab. (Closed)

Created:
11 years, 3 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Improve tab-closability of right-most tab. BUG=21903 TEST=Open 20 tabs. Put mouse over close button of some tab in the middle and keep clicking to close tabs. When the tab below the mouse is right-most, closing it should cause the other tabs to grow so that another close box ends up below the cursor (until the remaining tabs have reached the maximum tab width). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26354

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/cocoa/tab_strip_controller.mm View 1 chunk +13 lines, -5 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Nico
As discussed on IRC today.
11 years, 3 months ago (2009-09-16 05:48:05 UTC) #1
pink (ping after 24hrs)
11 years, 3 months ago (2009-09-16 14:37:16 UTC) #2
LGTM with comment.

http://codereview.chromium.org/196137/diff/1/2
File chrome/browser/cocoa/tab_strip_controller.mm (right):

http://codereview.chromium.org/196137/diff/1/2#newcode291
Line 291: if (static_cast<size_t>(index) != [tabArray_ count] - 1) {
i'd reverse the if/else cases here. check for the rightmost tab in the if, and
the else can be the normal case.

Powered by Google App Engine
This is Rietveld 408576698