Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1961363003: Log an immediate variant of FirstContentfulPaint. (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Log an immediate variant of FirstContentfulPaint. Our page load metrics are currently logged at the time a page is 'closed'. For example, when a tab is closed, or when a page is navigated away from. If a page stays open for a long period of time, we may log its metrics long after the events for those metrics occurred. This may cause issues such as logging metrics for events that happened on WiFi later, when the user is on 2G, or vice versa. We don't know how much of a problem this is, so to start, we're adding a single metric to allow us to track the difference between logging at the end of a page load and logging immediately after the page event occurred. If the difference is significant, this may motivate us to migrate other events to more immediate logging. NOTRY=true NOPRESUBMIT=true BUG=609660 Review-Url: https://codereview.chromium.org/1953673003 Cr-Commit-Position: refs/heads/master@{#392330} (cherry picked from commit 3e0a460bd23c5c2e25b8bf6b9813f8c78408a595)

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
Bryan McQuade
PTAL. This is a cherrypick into 2704.
4 years, 7 months ago (2016-05-10 18:14:13 UTC) #1
Charlie Harrison
On 2016/05/10 18:14:13, Bryan McQuade wrote: > PTAL. This is a cherrypick into 2704. lgtm
4 years, 7 months ago (2016-05-10 18:27:43 UTC) #2
Charlie Harrison
On 2016/05/10 18:14:13, Bryan McQuade wrote: > PTAL. This is a cherrypick into 2704. lgtm
4 years, 7 months ago (2016-05-10 18:27:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961363003/1
4 years, 7 months ago (2016-05-10 18:55:48 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-10 18:55:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961363003/1
4 years, 7 months ago (2016-05-10 18:59:02 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 19:01:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698