Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1961333002: Remove CPVT_Size and CPVT_FloatRange. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CPVT_Size and CPVT_FloatRange. - CPVT_Size is the same as CFX_SizeF - CPVT_FloatRange is unused. Committed: https://pdfium.googlesource.com/pdfium/+/cac1571474399a6b0271dde998970544543c921f

Patch Set 1 #

Total comments: 4

Patch Set 2 : CFX_SizeF #

Patch Set 3 : More point to size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -47 lines) Patch
M core/fpdfdoc/cpdf_variabletext.cpp View 1 2 3 chunks +9 lines, -13 lines 0 comments Download
M core/fpdfdoc/csection.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M core/fpdfdoc/ctypeset.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M core/fpdfdoc/doc_vt.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/include/cpdf_variabletext.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/pdf_vt.h View 1 2 5 chunks +10 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-05-10 18:25:55 UTC) #2
Wei Li
https://codereview.chromium.org/1961333002/diff/1/core/fpdfdoc/csection.h File core/fpdfdoc/csection.h (right): https://codereview.chromium.org/1961333002/diff/1/core/fpdfdoc/csection.h#newcode36 core/fpdfdoc/csection.h:36: CFX_PointF GetSectionSize(FX_FLOAT fFontSize); Is CFX_SizeF better here? https://codereview.chromium.org/1961333002/diff/1/core/fpdfdoc/ctypeset.h File ...
4 years, 7 months ago (2016-05-10 20:09:42 UTC) #3
Lei Zhang
https://codereview.chromium.org/1961333002/diff/1/core/fpdfdoc/csection.h File core/fpdfdoc/csection.h (right): https://codereview.chromium.org/1961333002/diff/1/core/fpdfdoc/csection.h#newcode36 core/fpdfdoc/csection.h:36: CFX_PointF GetSectionSize(FX_FLOAT fFontSize); On 2016/05/10 20:09:42, Wei Li wrote: ...
4 years, 7 months ago (2016-05-11 01:25:12 UTC) #4
Wei Li
lgtm
4 years, 7 months ago (2016-05-11 05:23:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961333002/40001
4 years, 7 months ago (2016-05-11 19:59:27 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 19:59:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/cac1571474399a6b0271dde998970544543c...

Powered by Google App Engine
This is Rietveld 408576698