Issue 196133030: Make max size and max length of strings consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196133030: Make max size and max length of strings consistent. (Closed)

Created:
6 years, 9 months ago by Yang

Modified:
6 years, 9 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make max size and max length of strings consistent. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20099

Patch Set 2 : fix #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -39 lines)			Patch
M	src/heap.cc	View	1	3 chunks	+5 lines, -8 lines	0 comments	Download
M	src/heap-inl.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	1	1 chunk	+6 lines, -12 lines	1 comment	Download
M	src/objects.h	View	1	3 chunks	+4 lines, -7 lines	0 comments	Download
M	src/runtime.cc	View	1	3 chunks	+3 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

https://codereview.chromium.org/196133030/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/196133030/diff/20001/src/hydrogen.cc#newcode1798 src/hydrogen.cc:1798: length, Add<HConstant>(String::kMaxLength), Token::LTE); Maybe we should use an HBoundsCheck ...

6 years, 9 months ago (2014-03-20 07:41:59 UTC) #3

Yang

6 years, 9 months ago (2014-03-20 08:33:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20099 (presubmit successful).

Expand Messages | Collapse Messages

Issue 196133030: Make max size and max length of strings consistent. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix #

Messages