Source/bindings/templates/attributes.cpp - Issue 196133029: Oilpan: move Location to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 196133029: Oilpan: move Location to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index d22962c427b0dd86950366466d92b4d777261f31..78e926b5eec318616c47ebbee81b3bab0cf4247a 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -227,7 +227,7 @@ v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info

{# impl #}

{% if attribute.put_forwards %}

{{cpp_class}}* proxyImpl = {{v8_class}}::toNative(info.Holder());

- RefPtr<{{attribute.idl_type}}> impl = WTF::getPtr(proxyImpl->{{attribute.name}}());

+ {{attribute.ref_ptr}}<{{attribute.idl_type}}> impl = WTF::getPtr(proxyImpl->{{attribute.name}}());

if (!impl)

return;

{% elif not attribute.is_static %}