pkg/docgen: more cleanup

pkg/docgen/lib/src/io.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This is a helper library to make working with io easier.
 library docgen.io;
 
 // TODO(janicejl): listDir, canonicalize, resolveLink, and linkExists are from
 // pub/lib/src/io.dart. If the io.dart file becomes a package, should remove
 // copy of the functions.
 
 import 'dart:collection';
 import 'dart:io';
 import 'package:path/path.dart' as path;
 
-/// Lists the contents of [dir]. If [recursive] is `true`, lists subdirectory
-/// contents (defaults to `false`). If [includeHidden] is `true`, includes files
-/// and directories beginning with `.` (defaults to `false`).
+/// Lists the contents of [dir].
+///
+/// If [recursive] is `true`, lists subdirectory contents (defaults to `false`).
+///
+/// Excludes files and directories beginning with `.`
 ///
 /// The returned paths are guaranteed to begin with [dir].
-List<String> listDir(String dir, {bool recursive: false,
-    bool includeHidden: false}) {
+List<String> listDir(String dir, {bool recursive: false}) {
   List<String> doList(String dir, Set<String> listedDirectories) {
     var contents = <String>[];
 
     // Avoid recursive symlinks.
     var resolvedPath = canonicalize(dir);
     if (listedDirectories.contains(resolvedPath)) return [];
 
     listedDirectories = new Set<String>.from(listedDirectories);
     listedDirectories.add(resolvedPath);
 
     var children = <String>[];
     for (var entity in new Directory(dir).listSync()) {
-      if (!includeHidden && path.basename(entity.path).startsWith('.')) {
+      if (path.basename(entity.path).startsWith('.')) {
         continue;
       }
 
       contents.add(entity.path);
       if (entity is Directory) {
         // TODO(nweiz): don't manually recurse once issue 4794 is fixed.
         // Note that once we remove the manual recursion, we'll need to
         // explicitly filter out files in hidden directories.
         if (recursive) {
           children.addAll(doList(entity.path, listedDirectories));
@@ skipping 101 matching lines @@
     seen.add(link);
     link = path.normalize(path.join(
         path.dirname(link), new Link(link).targetSync()));
   }
   return link;
 }
 
 /// Returns whether [link] exists on the file system. This will return `true`
 /// for any symlink, regardless of what it points at or whether it's broken.
 bool linkExists(String link) => new Link(link).existsSync();