| Index: src/ia32/code-stubs-ia32.cc
|
| diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
|
| index 2ef5a87da26eba19a5c4f9069bd90ebf8fef9633..4ff8a6817a502a3b160b3d51171cd536f4ea52fd 100644
|
| --- a/src/ia32/code-stubs-ia32.cc
|
| +++ b/src/ia32/code-stubs-ia32.cc
|
| @@ -170,6 +170,26 @@ void KeyedLoadFieldStub::InitializeInterfaceDescriptor(
|
| }
|
|
|
|
|
| +void StringLengthStub::InitializeInterfaceDescriptor(
|
| + Isolate* isolate,
|
| + CodeStubInterfaceDescriptor* descriptor) {
|
| + static Register registers[] = { edx, ecx };
|
| + descriptor->register_param_count_ = 2;
|
| + descriptor->register_params_ = registers;
|
| + descriptor->deoptimization_handler_ = NULL;
|
| +}
|
| +
|
| +
|
| +void KeyedStringLengthStub::InitializeInterfaceDescriptor(
|
| + Isolate* isolate,
|
| + CodeStubInterfaceDescriptor* descriptor) {
|
| + static Register registers[] = { edx, ecx };
|
| + descriptor->register_param_count_ = 2;
|
| + descriptor->register_params_ = registers;
|
| + descriptor->deoptimization_handler_ = NULL;
|
| +}
|
| +
|
| +
|
| void KeyedStoreFastElementStub::InitializeInterfaceDescriptor(
|
| Isolate* isolate,
|
| CodeStubInterfaceDescriptor* descriptor) {
|
| @@ -1046,26 +1066,6 @@ void FunctionPrototypeStub::Generate(MacroAssembler* masm) {
|
| }
|
|
|
|
|
| -void StringLengthStub::Generate(MacroAssembler* masm) {
|
| - // ----------- S t a t e -------------
|
| - // -- ecx : name
|
| - // -- edx : receiver
|
| - // -- esp[0] : return address
|
| - // -----------------------------------
|
| - Label miss;
|
| -
|
| - if (kind() == Code::KEYED_LOAD_IC) {
|
| - __ cmp(ecx, Immediate(masm->isolate()->factory()->length_string()));
|
| - __ j(not_equal, &miss);
|
| - }
|
| -
|
| - StubCompiler::GenerateLoadStringLength(masm, edx, eax, ebx, &miss);
|
| - __ bind(&miss);
|
| - StubCompiler::TailCallBuiltin(
|
| - masm, BaseLoadStoreStubCompiler::MissBuiltin(kind()));
|
| -}
|
| -
|
| -
|
| void StoreArrayLengthStub::Generate(MacroAssembler* masm) {
|
| // ----------- S t a t e -------------
|
| // -- eax : value
|
| @@ -1190,7 +1190,7 @@ void ArgumentsAccessStub::GenerateReadElement(MacroAssembler* masm) {
|
| }
|
|
|
|
|
| -void ArgumentsAccessStub::GenerateNewNonStrictSlow(MacroAssembler* masm) {
|
| +void ArgumentsAccessStub::GenerateNewSloppySlow(MacroAssembler* masm) {
|
| // esp[0] : return address
|
| // esp[4] : number of parameters
|
| // esp[8] : receiver displacement
|
| @@ -1215,7 +1215,7 @@ void ArgumentsAccessStub::GenerateNewNonStrictSlow(MacroAssembler* masm) {
|
| }
|
|
|
|
|
| -void ArgumentsAccessStub::GenerateNewNonStrictFast(MacroAssembler* masm) {
|
| +void ArgumentsAccessStub::GenerateNewSloppyFast(MacroAssembler* masm) {
|
| Isolate* isolate = masm->isolate();
|
|
|
| // esp[0] : return address
|
| @@ -1275,7 +1275,7 @@ void ArgumentsAccessStub::GenerateNewNonStrictFast(MacroAssembler* masm) {
|
| __ lea(ebx, Operand(ebx, ecx, times_2, FixedArray::kHeaderSize));
|
|
|
| // 3. Arguments object.
|
| - __ add(ebx, Immediate(Heap::kArgumentsObjectSize));
|
| + __ add(ebx, Immediate(Heap::kSloppyArgumentsObjectSize));
|
|
|
| // Do the allocation of all three objects in one go.
|
| __ Allocate(ebx, eax, edx, edi, &runtime, TAG_OBJECT);
|
| @@ -1293,7 +1293,7 @@ void ArgumentsAccessStub::GenerateNewNonStrictFast(MacroAssembler* masm) {
|
| __ test(ebx, ebx);
|
| __ j(not_zero, &has_mapped_parameters, Label::kNear);
|
| __ mov(edi, Operand(edi,
|
| - Context::SlotOffset(Context::ARGUMENTS_BOILERPLATE_INDEX)));
|
| + Context::SlotOffset(Context::SLOPPY_ARGUMENTS_BOILERPLATE_INDEX)));
|
| __ jmp(©, Label::kNear);
|
|
|
| __ bind(&has_mapped_parameters);
|
| @@ -1330,7 +1330,7 @@ void ArgumentsAccessStub::GenerateNewNonStrictFast(MacroAssembler* masm) {
|
| // Set up the elements pointer in the allocated arguments object.
|
| // If we allocated a parameter map, edi will point there, otherwise to the
|
| // backing store.
|
| - __ lea(edi, Operand(eax, Heap::kArgumentsObjectSize));
|
| + __ lea(edi, Operand(eax, Heap::kSloppyArgumentsObjectSize));
|
| __ mov(FieldOperand(eax, JSObject::kElementsOffset), edi);
|
|
|
| // eax = address of new object (tagged)
|
| @@ -1349,7 +1349,7 @@ void ArgumentsAccessStub::GenerateNewNonStrictFast(MacroAssembler* masm) {
|
| __ j(zero, &skip_parameter_map);
|
|
|
| __ mov(FieldOperand(edi, FixedArray::kMapOffset),
|
| - Immediate(isolate->factory()->non_strict_arguments_elements_map()));
|
| + Immediate(isolate->factory()->sloppy_arguments_elements_map()));
|
| __ lea(eax, Operand(ebx, reinterpret_cast<intptr_t>(Smi::FromInt(2))));
|
| __ mov(FieldOperand(edi, FixedArray::kLengthOffset), eax);
|
| __ mov(FieldOperand(edi, FixedArray::kHeaderSize + 0 * kPointerSize), esi);
|
| @@ -1475,7 +1475,7 @@ void ArgumentsAccessStub::GenerateNewStrict(MacroAssembler* masm) {
|
| __ j(zero, &add_arguments_object, Label::kNear);
|
| __ lea(ecx, Operand(ecx, times_2, FixedArray::kHeaderSize));
|
| __ bind(&add_arguments_object);
|
| - __ add(ecx, Immediate(Heap::kArgumentsObjectSizeStrict));
|
| + __ add(ecx, Immediate(Heap::kStrictArgumentsObjectSize));
|
|
|
| // Do the allocation of both objects in one go.
|
| __ Allocate(ecx, eax, edx, ebx, &runtime, TAG_OBJECT);
|
| @@ -1484,7 +1484,7 @@ void ArgumentsAccessStub::GenerateNewStrict(MacroAssembler* masm) {
|
| __ mov(edi, Operand(esi, Context::SlotOffset(Context::GLOBAL_OBJECT_INDEX)));
|
| __ mov(edi, FieldOperand(edi, GlobalObject::kNativeContextOffset));
|
| const int offset =
|
| - Context::SlotOffset(Context::STRICT_MODE_ARGUMENTS_BOILERPLATE_INDEX);
|
| + Context::SlotOffset(Context::STRICT_ARGUMENTS_BOILERPLATE_INDEX);
|
| __ mov(edi, Operand(edi, offset));
|
|
|
| // Copy the JS object part.
|
| @@ -1510,7 +1510,7 @@ void ArgumentsAccessStub::GenerateNewStrict(MacroAssembler* masm) {
|
|
|
| // Set up the elements pointer in the allocated arguments object and
|
| // initialize the header in the elements fixed array.
|
| - __ lea(edi, Operand(eax, Heap::kArgumentsObjectSizeStrict));
|
| + __ lea(edi, Operand(eax, Heap::kStrictArgumentsObjectSize));
|
| __ mov(FieldOperand(eax, JSObject::kElementsOffset), edi);
|
| __ mov(FieldOperand(edi, FixedArray::kMapOffset),
|
| Immediate(isolate->factory()->fixed_array_map()));
|
| @@ -2423,7 +2423,8 @@ static void GenerateRecordCallTarget(MacroAssembler* masm) {
|
|
|
| void CallFunctionStub::Generate(MacroAssembler* masm) {
|
| // ebx : feedback vector
|
| - // edx : (only if ebx is not undefined) slot in feedback vector (Smi)
|
| + // edx : (only if ebx is not the megamorphic symbol) slot in feedback
|
| + // vector (Smi)
|
| // edi : the function to call
|
| Isolate* isolate = masm->isolate();
|
| Label slow, non_function, wrap, cont;
|
| @@ -2481,7 +2482,7 @@ void CallFunctionStub::Generate(MacroAssembler* masm) {
|
| if (RecordCallTarget()) {
|
| // If there is a call target cache, mark it megamorphic in the
|
| // non-function case. MegamorphicSentinel is an immortal immovable
|
| - // object (undefined) so no write barrier is needed.
|
| + // object (megamorphic symbol) so no write barrier is needed.
|
| __ mov(FieldOperand(ebx, edx, times_half_pointer_size,
|
| FixedArray::kHeaderSize),
|
| Immediate(TypeFeedbackInfo::MegamorphicSentinel(isolate)));
|
| @@ -2529,7 +2530,8 @@ void CallFunctionStub::Generate(MacroAssembler* masm) {
|
| void CallConstructStub::Generate(MacroAssembler* masm) {
|
| // eax : number of arguments
|
| // ebx : feedback vector
|
| - // edx : (only if ebx is not undefined) slot in feedback vector (Smi)
|
| + // edx : (only if ebx is not the megamorphic symbol) slot in feedback
|
| + // vector (Smi)
|
| // edi : constructor function
|
| Label slow, non_function_call;
|
|
|
| @@ -4691,7 +4693,7 @@ void RecordWriteStub::GenerateIncremental(MacroAssembler* masm, Mode mode) {
|
| masm,
|
| kUpdateRememberedSetOnNoNeedToInformIncrementalMarker,
|
| mode);
|
| - InformIncrementalMarker(masm, mode);
|
| + InformIncrementalMarker(masm);
|
| regs_.Restore(masm);
|
| __ RememberedSetHelper(object_,
|
| address_,
|
| @@ -4706,13 +4708,13 @@ void RecordWriteStub::GenerateIncremental(MacroAssembler* masm, Mode mode) {
|
| masm,
|
| kReturnOnNoNeedToInformIncrementalMarker,
|
| mode);
|
| - InformIncrementalMarker(masm, mode);
|
| + InformIncrementalMarker(masm);
|
| regs_.Restore(masm);
|
| __ ret(0);
|
| }
|
|
|
|
|
| -void RecordWriteStub::InformIncrementalMarker(MacroAssembler* masm, Mode mode) {
|
| +void RecordWriteStub::InformIncrementalMarker(MacroAssembler* masm) {
|
| regs_.SaveCallerSaveRegisters(masm, save_fp_regs_mode_);
|
| int argument_count = 3;
|
| __ PrepareCallCFunction(argument_count, regs_.scratch0());
|
| @@ -4722,18 +4724,11 @@ void RecordWriteStub::InformIncrementalMarker(MacroAssembler* masm, Mode mode) {
|
| Immediate(ExternalReference::isolate_address(masm->isolate())));
|
|
|
| AllowExternalCallThatCantCauseGC scope(masm);
|
| - if (mode == INCREMENTAL_COMPACTION) {
|
| - __ CallCFunction(
|
| - ExternalReference::incremental_evacuation_record_write_function(
|
| - masm->isolate()),
|
| - argument_count);
|
| - } else {
|
| - ASSERT(mode == INCREMENTAL);
|
| - __ CallCFunction(
|
| - ExternalReference::incremental_marking_record_write_function(
|
| - masm->isolate()),
|
| - argument_count);
|
| - }
|
| + __ CallCFunction(
|
| + ExternalReference::incremental_marking_record_write_function(
|
| + masm->isolate()),
|
| + argument_count);
|
| +
|
| regs_.RestoreCallerSaveRegisters(masm, save_fp_regs_mode_);
|
| }
|
|
|
| @@ -5152,15 +5147,14 @@ void ArrayConstructorStub::GenerateDispatchToArrayStub(
|
| void ArrayConstructorStub::Generate(MacroAssembler* masm) {
|
| // ----------- S t a t e -------------
|
| // -- eax : argc (only if argument_count_ == ANY)
|
| - // -- ebx : feedback vector (fixed array or undefined)
|
| + // -- ebx : feedback vector (fixed array or megamorphic symbol)
|
| // -- edx : slot index (if ebx is fixed array)
|
| // -- edi : constructor
|
| // -- esp[0] : return address
|
| // -- esp[4] : last argument
|
| // -----------------------------------
|
| - Handle<Object> undefined_sentinel(
|
| - masm->isolate()->heap()->undefined_value(),
|
| - masm->isolate());
|
| + Handle<Object> megamorphic_sentinel =
|
| + TypeFeedbackInfo::MegamorphicSentinel(masm->isolate());
|
|
|
| if (FLAG_debug_code) {
|
| // The array construct code is only set for the global and natives
|
| @@ -5174,24 +5168,26 @@ void ArrayConstructorStub::Generate(MacroAssembler* masm) {
|
| __ CmpObjectType(ecx, MAP_TYPE, ecx);
|
| __ Assert(equal, kUnexpectedInitialMapForArrayFunction);
|
|
|
| - // We should either have undefined in ebx or a valid fixed array.
|
| + // We should either have the megamorphic symbol in ebx or a valid
|
| + // fixed array.
|
| Label okay_here;
|
| Handle<Map> fixed_array_map = masm->isolate()->factory()->fixed_array_map();
|
| - __ cmp(ebx, Immediate(undefined_sentinel));
|
| + __ cmp(ebx, Immediate(megamorphic_sentinel));
|
| __ j(equal, &okay_here);
|
| __ cmp(FieldOperand(ebx, 0), Immediate(fixed_array_map));
|
| __ Assert(equal, kExpectedFixedArrayInRegisterEbx);
|
|
|
| - // edx should be a smi if we don't have undefined in ebx.
|
| + // edx should be a smi if we don't have the megamorphic symbol in ebx.
|
| __ AssertSmi(edx);
|
|
|
| __ bind(&okay_here);
|
| }
|
|
|
| Label no_info;
|
| - // If the feedback vector is undefined, or contains anything other than an
|
| - // AllocationSite, call an array constructor that doesn't use AllocationSites.
|
| - __ cmp(ebx, Immediate(undefined_sentinel));
|
| + // If the feedback vector is the megamorphic sentinel, or contains anything
|
| + // other than an AllocationSite, call an array constructor that doesn't use
|
| + // AllocationSites.
|
| + __ cmp(ebx, Immediate(megamorphic_sentinel));
|
| __ j(equal, &no_info);
|
| __ mov(ebx, FieldOperand(ebx, edx, times_half_pointer_size,
|
| FixedArray::kHeaderSize));
|
|
|