ui/views/controls/button/checkbox.cc - Issue 196133012: Fix incorrect use of AXState caused when refactoring two enums into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/checkbox.cc

Issue 196133012: Fix incorrect use of AXState caused when refactoring two enums into one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename SetStateFlag -> AddStateFlag Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/checkbox.cc

diff --git a/ui/views/controls/button/checkbox.cc b/ui/views/controls/button/checkbox.cc

index 2389b62bbf43c9b326b3697a6372a0a3ff77065a..22c5f88e2d6c6a61783212485a2873df25d34231 100644

--- a/ui/views/controls/button/checkbox.cc

+++ b/ui/views/controls/button/checkbox.cc

@@ -97,7 +97,8 @@ const char* Checkbox::GetClassName() const {

void Checkbox::GetAccessibleState(ui::AXViewState* state) {

LabelButton::GetAccessibleState(state);

state->role = ui::AX_ROLE_CHECK_BOX;

- state->state = checked() ? ui::AX_STATE_CHECKED : 0;

+ if (checked())

+ state->AddStateFlag(ui::AX_STATE_CHECKED);

}

void Checkbox::OnFocus() {

« no previous file with comments | « ui/views/accessibility/native_view_accessibility_win.cc ('k') | ui/views/controls/button/custom_button.cc » ('j') | no next file with comments »