chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 196133012: Fix incorrect use of AXState caused when refactoring two enums into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 196133012: Fix incorrect use of AXState caused when refactoring two enums into one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add dependency Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/download/download_item_view.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_button.cc » ('j') | ui/accessibility/ax_view_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc

index df73e4c8b9699a93eb0a1de6b608df224339c5f2..64640c92fd920d24e1e76864bf5d8bf23b74bc82 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -1138,7 +1138,7 @@ void LocationBarView::GetAccessibleState(ui::AXViewState* state) {

state->selection_end = entry_end;

if (is_popup_mode_) {

- state->state |= ui::AX_STATE_READ_ONLY;

+ state->SetStateFlag(ui::AX_STATE_READ_ONLY);

} else {

state->set_value_callback =

base::Bind(&LocationBarView::AccessibilitySetValue,