Issue 196133006: Colormatrix GPU fix with saturated alpha.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196133006: Colormatrix GPU fix with saturated alpha. (Closed)

Created:
6 years, 9 months ago by Stephen White

Modified:
6 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix GPU colormatrix color filter with saturated alpha. Clamp RGBA values before unpremultiplying, to match the raster path. This causes a problem when the resulting alpha is >1.0, resulting in overly saturated RGB. Covered by the setYUV2RGB() test case in the colormatrix GM. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=13778

Patch Set 1 #

Patch Set 2 : Update codereview link #

Patch Set 3 : Fix typo #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/effects/SkColorMatrixFilter.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

6 years, 9 months ago (2014-03-12 21:37:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r13778 (presubmit successful).

Expand Messages | Collapse Messages