Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1961323003: [NTP Snippets] Fix crash on snippet dismiss (Closed)

Created:
4 years, 7 months ago by dgn
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, dgn+watch_chromium.org, mcwilliams+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Fix crash on snippet dismiss BUG=610665 Committed: https://crrev.com/e00cf466b30ddf9dce47a809aab91251eb76fa93 Cr-Commit-Position: refs/heads/master@{#392884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgn
PTAL
4 years, 7 months ago (2016-05-10 17:06:03 UTC) #2
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-11 08:45:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961323003/1
4 years, 7 months ago (2016-05-11 09:21:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 09:26:05 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 09:27:15 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e00cf466b30ddf9dce47a809aab91251eb76fa93
Cr-Commit-Position: refs/heads/master@{#392884}

Powered by Google App Engine
This is Rietveld 408576698